From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `affixation-function`: Allow only three-element lists Date: Tue, 27 Apr 2021 19:45:38 +0300 Organization: LINKOV.NET Message-ID: <874kfrr80d.fsf@mail.linkov.net> References: <87h7jujmbn.fsf@mail.linkov.net> <02eb444c-d8e2-8271-1edc-b02b3ce7f64c@daniel-mendler.de> <87wnsqgl2o.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1741"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Stefan Monnier , emacs-devel@gnu.org To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 27 18:50:16 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbQue-0000Ld-R7 for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Apr 2021 18:50:16 +0200 Original-Received: from localhost ([::1]:51862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbQud-0007yV-7k for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Apr 2021 12:50:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbQqk-0004ih-PJ for emacs-devel@gnu.org; Tue, 27 Apr 2021 12:46:17 -0400 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:36219) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbQqh-0005wC-P1 for emacs-devel@gnu.org; Tue, 27 Apr 2021 12:46:14 -0400 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id DAAF810000A; Tue, 27 Apr 2021 16:46:05 +0000 (UTC) In-Reply-To: (Daniel Mendler's message of "Sun, 25 Apr 2021 23:04:15 +0200") Received-SPF: pass client-ip=217.70.178.231; envelope-from=juri@linkov.net; helo=relay11.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268538 Archived-At: > Okay, fair enough. I am fine if the `cl-assert` is removed from the > patch. The other changes should be kept though, such that we do not violate > the more restricted specification. Other completion UIs may not support the > two-element affixations which are then still accidentally allowed by the > default completion UI. The `cl-assert` is just a cheap check to ensure that > no violating affixation functions are accidentally reintroduced. But you > are right that this is not fail-safe. Do you want me to send an updated > patch with the `cl-assert` removed? Your already sent patch is fine, thanks. I only removed `cl-assert`, added a fix in the Info node "Programmed Completion", and pushed to master.