From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Omar Polo Newsgroups: gmane.emacs.devel Subject: Re: On the adoption of transient.el Date: Fri, 06 Aug 2021 19:20:09 +0200 Message-ID: <874kc2o5h2.fsf@omarpolo.com> References: <877di4on3d.fsf@posteo.net> <87im1oy6mw.fsf@posteo.net> <87y29hihea.fsf@posteo.net> <87sfzonu6k.fsf@ucl.ac.uk> <878s1gqlop.fsf@gmail.com> <8735ronpo0.fsf@ucl.ac.uk> <83lf5gjgtp.fsf@gnu.org> <87eeb8gdbq.fsf@telefonica.net> <877dgzebux.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10922"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.15; emacs 28.0.50 Cc: =?utf-8?Q?=C3=93scar?= Fuentes , Juri Linkov , emacs-devel@gnu.org, John Yates To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 06 19:21:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mC3Wu-0002cL-T6 for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Aug 2021 19:21:08 +0200 Original-Received: from localhost ([::1]:46234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mC3Wt-0007yL-H9 for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Aug 2021 13:21:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC3WC-00075V-AO for emacs-devel@gnu.org; Fri, 06 Aug 2021 13:20:24 -0400 Original-Received: from mail.omarpolo.com ([144.91.116.244]:53333) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mC3W9-0000kC-2o for emacs-devel@gnu.org; Fri, 06 Aug 2021 13:20:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omarpolo.com; s=20200327; t=1628270411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WAjkA3KvaJ3SqJlC5Bl9A2Vngs5eVhDZenilUa4efuQ=; b=JvSGrSKLpVpweP2Bok15TxxyMtxQ7tBk2wmO5O8fhmNHY/c3knC8AuZk51mBY7xYRBY3dT txc7DJUPt7OGeJ48mm1pP54Oe+WwZLD5s39fDcno0q4ooujSNvsc+OkP1Mz71vwl9ZrvA4 2bzLvFIEL05rQXyppRL4LLEptiRxqdM= Original-Received: from localhost (host-79-30-239-140.retail.telecomitalia.it [79.30.239.140]) by mail.omarpolo.com (OpenSMTPD) with ESMTPSA id 0508ae1f (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 6 Aug 2021 19:20:11 +0200 (CEST) Original-Received: from venera (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id b2cf6bc9; Fri, 6 Aug 2021 19:20:09 +0200 (CEST) In-reply-to: Received-SPF: pass client-ip=144.91.116.244; envelope-from=op@omarpolo.com; helo=mail.omarpolo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272143 Archived-At: Stefan Monnier writes: > John Yates [2021-08-06 08:39:51] wrote: >> On Thu, Aug 5, 2021 at 7:41 PM Juri Linkov wrote: >>> Currently I'm finishing implementation of a new vc command ... >> [..SNIP..] >>> it works by running three git commands: >>> >>> `git stash push -m stash_name -- list_of_file_names_from_diff` >>> `cat diff_buffer.patch | git am` # should also handle return code >>> `git stash pop -q` >> >> Will this new command work with all vc supported [D]VCSs? > > I don't know the practical answer, but I do know in theory it could: > we just need to add generic support for "stash". > > > Stefan Sorry for hijacking the thread, but given that the we ended up talking about stash support for vc, I thought to share this. I'm working (very very slowly) on vc-got[0], a vc backend for the GoT[1] vcs. One of the things I did was to add a shash command, and while very primitive, it seems to work decently. It adds an additional column in vc-dir to show the stage status of the file (there are a couple of screenshot in the readme). The implementation is quite messy because vc-dir-move-to-goal-column hardcodes the value of 25 and I wanted to add an additional column with the stage status *before* the file status. I also had to add an additional command, vc-got-stage-commit, because vc-next-action (and the rest of vc) assumes that we're working with file sets. The process of (un)staging hunks is still pretty tedious since it's basically a wrapper around `got stage -p' (the equivalent of `git add -p') using y-or-n-p... So, all of this to say that I'd really like if someone would try to add something to vc-mode to stage (and un-stage!) individual hunks, and I'd like to help in that case. I'm not stepping up myself because I don't feel qualified enough (^_^); Cheers, [0]: https://git.omarpolo.com/vc-got or https://github.com/omar-polo/vc-got/ [1]: https://gameoftrees.org/