From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.devel Subject: Re: Allowing symlinked dir-locals files? Date: Mon, 16 Aug 2021 20:39:21 +0200 Message-ID: <874kbpkzdy.fsf@igel.home> References: <8735r91d73.fsf@wavexx.thregr.org> <83o89x6yyn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27372"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Cc: Yuri D'Elia , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 16 20:41:06 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mFhXl-0006p4-C0 for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Aug 2021 20:41:05 +0200 Original-Received: from localhost ([::1]:35280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFhXj-00067C-Hm for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Aug 2021 14:41:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFhWD-0004bz-Qi for emacs-devel@gnu.org; Mon, 16 Aug 2021 14:39:36 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.9]:38581) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFhWB-0004IE-C6; Mon, 16 Aug 2021 14:39:29 -0400 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4GpNHH39f8z1qw93; Mon, 16 Aug 2021 20:39:23 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4GpNHH2nv2z1r6P2; Mon, 16 Aug 2021 20:39:23 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 628r27gbpi1L; Mon, 16 Aug 2021 20:39:22 +0200 (CEST) X-Auth-Info: yTE35ZW34MJYhheHxc+UCeJf8n44VKDZk22OebRTWdzI3+BKk5iYr8j9Sd28qdZy Original-Received: from igel.home (ppp-46-244-185-182.dynamic.mnet-online.de [46.244.185.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 16 Aug 2021 20:39:22 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 1000) id 7B2CA2C2640; Mon, 16 Aug 2021 20:39:21 +0200 (CEST) X-Yow: Could I have a drug overdose? In-Reply-To: <83o89x6yyn.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 16 Aug 2021 21:12:16 +0300") Received-SPF: pass client-ip=212.18.0.9; envelope-from=whitebox@nefkom.net; helo=mail-out.m-online.net X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272458 Archived-At: On Aug 16 2021, Eli Zaretskii wrote: >> Looking at the current files.el:4330, we explicitly check if the file is >> a regular file. Why is that a problem? If the symlink points to a regular file, it is still a file-regular-p. > Yes. It could also be a symlink injected by malevolent hackers. Is that different from a regular file injected by malevolent hackers? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."