unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Adam Porter <adam@alphapapa.net>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] tab-line: New tab-line-tab-face-modified face
Date: Sat, 25 Sep 2021 22:18:52 +0300	[thread overview]
Message-ID: <874ka8a2g3.fsf@mail.linkov.net> (raw)
In-Reply-To: <87k0j5bp1b.fsf@alphapapa.net> (Adam Porter's message of "Fri, 24 Sep 2021 17:13:20 -0500")

>> But why font-lock-doc-face?  Have you tried to change tab background color?
>> I guess this would be more visually pleasing.  Or maybe not.  This needs
>> more experimentation.
>
> Because in the default theme, it results in text that's a dark red,
> which is easily distinguished against the default tab background color,
> while still being readable (IMHO).  It reminds me of other editors I've
> used that use the red color to indicate a modified tab, so I think it
> should be somewhat familiar to users.  And by using a "font-lock-" face,
> it will be themed automatically by common third-party themes; while that
> doesn't guarantee it will look good with any theme by default, it should
> help.

Ah, this explains everything - a dark red makes sense, but long ago
I customized this face to green and forgot that by default it's dark red :)

Thanks for the patch, now applied.



  reply	other threads:[~2021-09-25 19:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-24  4:57 [PATCH] tab-line: New tab-line-tab-face-modified face Adam Porter
2021-09-24  6:38 ` Juri Linkov
2021-09-24  7:09   ` Adam Porter
2021-09-24 10:29     ` Stefan Kangas
2021-09-24 15:42     ` Juri Linkov
2021-09-24 22:13       ` Adam Porter
2021-09-25 19:18         ` Juri Linkov [this message]
2021-09-26  0:14           ` Adam Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ka8a2g3.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=adam@alphapapa.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).