From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: David Engster Newsgroups: gmane.emacs.devel Subject: Re: Time to merge scratch/correct-warning-pos into master, perhaps? Date: Sat, 19 Feb 2022 18:43:34 +0100 Message-ID: <874k4u92gp.fsf@randomsample> References: <83a6f631k3.fsf@gnu.org> <838ruq2z5t.fsf@gnu.org> <83v8xt20db.fsf@gnu.org> <83ee4gyzrh.fsf@gnu.org> <83v8xryh4d.fsf@gnu.org> <831qzyzt5t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18107"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: mattiase@acm.org, emacs-devel@gnu.org, gregory@heytings.org, monnier@iro.umontreal.ca, Alan Mackenzie , larsi@gnus.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 19 18:48:01 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLTpx-0004Xf-4G for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Feb 2022 18:48:01 +0100 Original-Received: from localhost ([::1]:41968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nLTpv-0006f9-Ut for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Feb 2022 12:47:59 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLTml-0005Ah-QG for emacs-devel@gnu.org; Sat, 19 Feb 2022 12:44:43 -0500 Original-Received: from zplane.randomsample.de ([192.145.45.252]:46656) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLTmE-00055A-Dm; Sat, 19 Feb 2022 12:44:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=euGWocLiJZ54ny2j05QR4Hr12puRgcd/RFvCYA137zI=; b=c/KaNrTLU2a1/RM2vOYxY428t qg+UkZX5bKi7KdvouNtspBP3EBi43x4bfeEn7s5Fy5RZdNBYKoPSCtgP3PuaD7wdpIFkHUzDeRv0i xJ9Dy1L2HQ2s8GHywFT9ecbOadf6Izeu7FaB8nA4YcnolneNJZIx+goL49XoxDpN97naYSDE3XcG0 pbHEINhkVx1ejjo2ubBsRJ3e7R+kqh5smuTFKSxWOOoJdGt6nNSxz72VGO+FF1i3090Ii/AL9vYDa KV92RHTdlChs7M3JZmSDaG4WShFyRG7QW2BWywixWHHXTLYULCGU/ZNFgTBR6YhWCdfA2LbnnRheZ bOkD094Wg==; Original-Received: from ip5f5abad6.dynamic.kabel-deutschland.de ([95.90.186.214] helo=void) by zplane.randomsample.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nLTlf-0003K6-LQ; Sat, 19 Feb 2022 18:43:36 +0100 In-Reply-To: <831qzyzt5t.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Feb 2022 19:02:22 +0200") Received-SPF: pass client-ip=192.145.45.252; envelope-from=deng@randomsample.de; helo=zplane.randomsample.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286481 Archived-At: >> Date: Sat, 19 Feb 2022 16:42:07 +0000 >> Cc: gregory@heytings.org, monnier@iro.umontreal.ca, mattiase@acm.org, >> larsi@gnus.org, emacs-devel@gnu.org >> From: Alan Mackenzie >> >> I haven't got any useful information out of the exercise, so far. I >> can't help feeling that I'm missing something. Is there anything I ought >> to be doing that I've not yet done? > > Maybe you should make EQ real function, with an attribute that would > preclude its inlining. > > I have no other ideas. Maybe someone else does. Making EQ a non-inlined function would be the first step. But since perf is a sampling profiler, it is not easy to measure something that's already very quick - it's simply quite unlikely that perf would hit it, unless it is called extremely often. The default sampling frequency of perf is 1kHz, so the first thing you can try is to increase that, so that it becomes more likely to hit EQ (see the '-F' switch for 'perf record'). However, it might simply be that a tracing profiler would be the better choice here, so maybe look into good old gprof or valgrind. Or maybe even instrument EQ yourself and count cycles between start and end. -David