From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix bookmark-bmenu-list sorting. Date: Mon, 21 Mar 2022 09:14:13 -0500 Message-ID: <874k3rtmtm.fsf@red-bean.com> References: <875yovm1m6.fsf@elite.giraud> <87v8wvkk64.fsf@red-bean.com> <83v8wuj3v0.fsf@gnu.org> <87tucewgu7.fsf@red-bean.com> <83lexqi3z9.fsf@gnu.org> <87tuceuo4b.fsf@red-bean.com> <83czj2hrdv.fsf@gnu.org> <87a6e5lui6.fsf@elite.giraud> <837d99j10x.fsf@gnu.org> <874k4dlpeg.fsf@elite.giraud> <834k4divrt.fsf@gnu.org> <87wnh9k43g.fsf@elite.giraud> <83v8wth5lh.fsf@gnu.org> <87h78afndq.fsf@red-bean.com> <87zgm25d9o.fsf@elite.giraud> <87lex4ura5.fsf@red-bean.com> <87r16vhha4.fsf@elite.giraud> Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3142"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Manuel Giraud Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 21 15:16:10 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWIpN-0000WX-2T for ged-emacs-devel@m.gmane-mx.org; Mon, 21 Mar 2022 15:16:09 +0100 Original-Received: from localhost ([::1]:34996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nWIpL-0001x2-Nm for ged-emacs-devel@m.gmane-mx.org; Mon, 21 Mar 2022 10:16:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWIna-0008RB-3j for emacs-devel@gnu.org; Mon, 21 Mar 2022 10:14:18 -0400 Original-Received: from sanpietro.red-bean.com ([45.79.25.59]:46748) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWInY-0002QR-5I; Mon, 21 Mar 2022 10:14:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:In-Reply-To:Date:Reply-To:References:Subject:Cc:To: From:Sender:Content-ID:Content-Description; bh=csAV+e56RJxbFFJkxCUo604hSkHxjTQXJ2Ity1FxOL0=; t=1647872055; x=1649081655; b=mF2Po6VPFxKvjep2ix1KUE1z9DFiCzHqj2ntJ226KkxatCEfsUSrYSjvxxh5E8WmAxKMJEgDOrh 96TNwd6lQr+I0h3kPHEz2m2nxdlJDBO4dTEBEGB1ElXGlRqFCe/Vk3Pn6ZiVbUA3EiwE3CMDnPNb/ L7UB9XoaxCg4SBTPHZgReShMpQrIlgQh7wy44BAWahKRntboac78WxjfOiYnNFXy63K/fWhOapRIT 6Z+8Wa6g/lfsrVBhN6QZ0xE14wfzkW+f5YCqoOALhpo/XGxJUHgF1FUrlomqm2q2rtlf9LvIkfzTp AYhs53Jhjlz67QAwF9FoGZc90ak0ntLWFMCw==; Original-Received: from [12.106.183.66] (port=13059 helo=hummy) by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nWInW-0092wi-6w; Mon, 21 Mar 2022 14:14:14 +0000 In-Reply-To: <87r16vhha4.fsf@elite.giraud> (Manuel Giraud's message of "Mon, 21 Mar 2022 08:54:43 +0100") Received-SPF: pass client-ip=45.79.25.59; envelope-from=kfogel@red-bean.com; helo=sanpietro.red-bean.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287338 Archived-At: On 21 Mar 2022, Manuel Giraud wrote: >> In the tabulated-list header line at the top of the buffer, we=20 >> have >> the expected three columns: "Bookmark", "Type", and "File". The=20 >> first >> column, "Bookmark", has a down-triangle / up-triangle toggle=20 >> for >> switching between descending and ascending sort by bookmark=20 >> name. But >> if `bookmark-sort-flag' is nil, then when the buffer is=20 >> regenerated >> the bookmarks will be listed in creation-date order -- and the >> triangular toggle will just keep whichever value the triangle=20 >> had >> already. > >So yes that was what I was talking about (only better described=20 >=F0=9F=98=85). Ah, got it, thanks! >> Maybe the right fix for that is for the buffer to somehow=20 >> indicate >> *which* property the bookmarks are sorted by -- name or=20 >> creation-date >> -- and make sure that the triangle always reflects the sorting >> direction of whichever thing is currently being sorted on.=20 >> However, >> before I go down that road, I'd like to fully understand your=20 >> initial >> "one minor thing" bug report above first. > >Or maybe you can =C2=ABreset the state=C2=BB of the tabulated-list (as it= =20 >is on >first bookmark-bmenu-list call)? But I don't really know how >tabulated-list works. Okay -- I'll figure it out and Do The Right Thing. Thank you,=20 Manuel. Best regards, -Karl