unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Karl Fogel <kfogel@red-bean.com>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: [PATCH] Fix bookmark-bmenu-list sorting.
Date: Mon, 21 Mar 2022 09:14:13 -0500	[thread overview]
Message-ID: <874k3rtmtm.fsf@red-bean.com> (raw)
In-Reply-To: <87r16vhha4.fsf@elite.giraud> (Manuel Giraud's message of "Mon, 21 Mar 2022 08:54:43 +0100")

On 21 Mar 2022, Manuel Giraud wrote:
>> In the tabulated-list header line at the top of the buffer, we 
>> have
>> the expected three columns: "Bookmark", "Type", and "File". The 
>> first
>> column, "Bookmark", has a down-triangle / up-triangle toggle 
>> for
>> switching between descending and ascending sort by bookmark 
>> name.  But
>> if `bookmark-sort-flag' is nil, then when the buffer is 
>> regenerated
>> the bookmarks will be listed in creation-date order -- and the
>> triangular toggle will just keep whichever value the triangle 
>> had
>> already.
>
>So yes that was what I was talking about (only better described 
>😅).

Ah, got it, thanks!

>> Maybe the right fix for that is for the buffer to somehow 
>> indicate
>> *which* property the bookmarks are sorted by -- name or 
>> creation-date
>> -- and make sure that the triangle always reflects the sorting
>> direction of whichever thing is currently being sorted on. 
>> However,
>> before I go down that road, I'd like to fully understand your 
>> initial
>> "one minor thing" bug report above first.
>
>Or maybe you can «reset the state» of the tabulated-list (as it 
>is on
>first bookmark-bmenu-list call)? But I don't really know how
>tabulated-list works.

Okay -- I'll figure it out and Do The Right Thing.  Thank you, 
Manuel.

Best regards,
-Karl



  reply	other threads:[~2022-03-21 14:14 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03 16:39 [PATCH] Fix bookmark-bmenu-list sorting Manuel Giraud
2022-03-03 17:41 ` Karl Fogel
2022-03-03 18:19   ` Eli Zaretskii
2022-03-04  3:13     ` Karl Fogel
2022-03-04  7:14       ` Eli Zaretskii
2022-03-04  8:18         ` Karl Fogel
2022-03-04 11:46           ` Eli Zaretskii
2022-03-04 13:25             ` Manuel Giraud
2022-03-04 13:33               ` Eli Zaretskii
2022-03-04 15:15                 ` Manuel Giraud
2022-03-04 15:26                   ` Eli Zaretskii
2022-03-04 17:41                     ` Manuel Giraud
2022-03-04 19:37                       ` Eli Zaretskii
2022-03-07  3:32                         ` Karl Fogel
2022-03-07  9:21                           ` Manuel Giraud
2022-03-20 23:40                             ` Karl Fogel
2022-03-21  7:54                               ` Manuel Giraud
2022-03-21 14:14                                 ` Karl Fogel [this message]
2022-04-20 18:09                             ` [PATCH] Improve sorting in the bookmark list buffer Karl Fogel
2022-04-20 19:02                               ` Eli Zaretskii
2022-04-20 19:49                                 ` Karl Fogel
2022-04-24 17:30                                 ` Karl Fogel
2022-04-24 18:13                                   ` Eli Zaretskii
2022-04-24 19:10                                     ` Karl Fogel
2022-04-25  9:35                                       ` Manuel Giraud
2022-04-25 17:50                                         ` Karl Fogel
2022-04-26  7:51                                           ` Manuel Giraud
2022-03-07 13:12                           ` [PATCH] Fix bookmark-bmenu-list sorting Eli Zaretskii
2022-03-07 19:03                             ` Karl Fogel
2022-03-07  5:17                         ` Karl Fogel
2022-03-04  8:34         ` Manuel Giraud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874k3rtmtm.fsf@red-bean.com \
    --to=kfogel@red-bean.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=manuel@ledu-giraud.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).