unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: emacs-devel@gnu.org
Cc: Lars Ingebrigtsen <larsi@gnus.org>
Subject: Re: master c8bde5b0a3: Fix two no-X compilation warnings
Date: Wed, 23 Mar 2022 08:55:03 +0800	[thread overview]
Message-ID: <874k3pebdk.fsf@yahoo.com> (raw)
In-Reply-To: <20220322201440.6B4ABC01680@vcs2.savannah.gnu.org> (Lars Ingebrigtsen's message of "Tue, 22 Mar 2022 16:14:40 -0400 (EDT)")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> -  (or (stringp x-resource-name)
> +  (when (boundp 'x-resource-name)
> +    (unless (stringp x-resource-name)
>        (let (i)
>  	(setq x-resource-name (copy-sequence invocation-name))
>  
>  	;; Change any . or * characters in x-resource-name to hyphens,
>  	;; so as not to choke when we use it in X resource queries.
>  	(while (setq i (string-match "[.*]" x-resource-name))
> -	  (aset x-resource-name i ?-))))
> +	  (aset x-resource-name i ?-)))))
>  
>    ;; Setup the default fontset.
>    (create-default-fontset)

I thought the right thing to do in this particular situation was to add
a defvar form that read something like this:

(defvar x-resource-name)

Thanks.



       reply	other threads:[~2022-03-23  0:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164798008014.25625.1667266381969929314@vcs2.savannah.gnu.org>
     [not found] ` <20220322201440.6B4ABC01680@vcs2.savannah.gnu.org>
2022-03-23  0:55   ` Po Lu [this message]
2022-03-23 11:17     ` master c8bde5b0a3: Fix two no-X compilation warnings Lars Ingebrigtsen
2022-03-23 11:48       ` Po Lu
2022-03-23 11:50         ` Lars Ingebrigtsen
2022-03-23 12:57           ` Po Lu
2022-03-23 13:09           ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874k3pebdk.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).