From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 5743b74d4b 1/2: Improve mouse dragging Date: Fri, 13 May 2022 20:45:23 +0800 Message-ID: <874k1tvbx8.fsf@yahoo.com> References: <83sfpfp5p1.fsf@gnu.org> <87sfpfx8j8.fsf@yahoo.com> <83ilqaq5o9.fsf@gnu.org> <87fsleykdp.fsf@yahoo.com> <83h75uq4id.fsf@gnu.org> <87bkw2yjeg.fsf@yahoo.com> <83ee0yq2pg.fsf@gnu.org> <8735hexoo3.fsf@yahoo.com> <83h75unf94.fsf@gnu.org> <87czghx67w.fsf@yahoo.com> <83a6blope5.fsf@gnu.org> <878rr5x46w.fsf@yahoo.com> <837d6poh7t.fsf@gnu.org> <87v8u9vgb6.fsf@yahoo.com> <83wnepmy7q.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21696"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 13 15:02:44 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1npUwO-0005Uj-7y for ged-emacs-devel@m.gmane-mx.org; Fri, 13 May 2022 15:02:44 +0200 Original-Received: from localhost ([::1]:44630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npUwM-0008PQ-Qb for ged-emacs-devel@m.gmane-mx.org; Fri, 13 May 2022 09:02:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npUfq-0005l9-I9 for emacs-devel@gnu.org; Fri, 13 May 2022 08:45:38 -0400 Original-Received: from sonic311-23.consmr.mail.ne1.yahoo.com ([66.163.188.204]:41334) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1npUfn-0002Dx-Ut for emacs-devel@gnu.org; Fri, 13 May 2022 08:45:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1652445933; bh=/1B/O34uob/D5aku0e9dhh1FYAXA34K+9pr7vw01t3Q=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=hawBtvYwtLgMesoM4Zgsff+zHsF2O6pbm5ZUK7lyrebdwF9ewm2pFfauVPx89KRjW7vOnVcCm8BHJ6pK4NxZb5ZcUfIFFQxUaodLp6tOkzNj6lJMQYpeYhndJWRM6idF+dI22Az2mgkFNkngETwv8SfXXngPQ13FVGqTTkkYfF9vouEMIOeNQudoc1e+ZN96SVWSvENuuJXt0FaGw9U5bRamrnrmM684zby3+RwrGj6nWLm7nrzLTvrgYM0xGjgWRFC5fzruR/YQYJckzDvrhigtVrWy+0+FiuWy/vIyyFvuSfDEOZhG/JtYjZnNp0OBZ1OmVYzQOULzcC84YGe7Rg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1652445933; bh=5cuipKKDn7Ie/rLbUIIKgizgngSEJPjPaYdFylp8fRK=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=nOTxZeg9KiSlDkhQ+l09wNuMuFWpodKGyu5UVQCMn6rUlQqboX6WtSbfGctGG1aLs95ON1Jlycuise+lputBXYk4RCAj9igX95uSpi/c33Gpfo4oeh9BoJWut9oTfYi64yLxGlT21lSpNMMxLxwl3aLXkZdrkJGDl82nCkPhR9Pdak+wpCNeLcIQSDjTn3yYW96uwdpOy+QgCfluh0QHiefaSgP72VEi9ajXTQjwoGYRDrIGIxHwIbb3sn/UUrXYCelDhfbiYmWnko80qBHjzixsze50j+vMqwqSHvACGMJZIRDuGWX9C2ZCI5h8ff/nZVNIXoxGShVWpjsuKnYiVQ== X-YMail-OSG: ph.AUrMVM1lxQC.5P1G6zA9dd4HHV_5s97x0CFEATL9fk91RP5pM77yGsCEPEsb ZeL1z2seXpgvZksWFCUJZ2uMYOYk6DuHEi8KolRz.4v6H1NU8v3mqsKEIlY6sXsJGM4b42AUR.KX Zb8u3IEBABBzduxlZOpDSxMuFle1KhRuBibXYu.abmbP2aVdaurBy.V1GwScWiQxftoYmZBe5JOZ NmJ1S6mFnwhK.PtYeX8GM0jlIiIRIRyYvZ7VoH25gBwWY65lxGIQRsGALdW7kgD7KdnECHzw8NVZ KZ.0AfXJSQRHJA2SXWgWNaZZnrLWDF8aRaxQoo8Fs_icaltoq30KdDZCQaeSmqDezuLjFIT3Mq25 GvGx9WwAdf2lA.oW1Yg2LCAdJesFqum62kfgigWPr7FYJwex31V3v5MIfNeWYyeO9wdihogYXxtp dYNNG_COHDUPU91e0THzB9ExQceYeDSjyx3B2uBMoaRmknCNn8_mgVU9QnHROj_.aOP2K4io1KRz aPdzWJyUrtaj0Z4Tf6hoG4x7D0sVFA40anG2gTWUFnl5iZyQ5CIy_BEHM8bgqvBsrViTctBSeLH4 QUGLvDDg2mnnqo6rTX8e8o8DVj.qdlxbx_U.H3gUmS_84qW2KVkHop6PR72XWNm14_OTSb7Hre15 MEG3r1rQ53L9fMGfAQ8THbU3.sXL8fZ7_nycw_yMwwXhgSBAwLJAHW94psrEdlQdrck0m5VY.jgJ 4NNvoRp111AQ_sj0tAhM036YasRCNxMeeqPo4fcZfE75U7O2gQ.c_01A2szGF.OfspYmikz2MSGV A8yGakIXQr_cmWBqAMIzslFYjWisSnMQUGWVdHVKAx X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ne1.yahoo.com with HTTP; Fri, 13 May 2022 12:45:33 +0000 Original-Received: by hermes--canary-production-sg3-856bf69955-j4wlk (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 480087e8235cf6ca5ceccb5d1c054db0; Fri, 13 May 2022 12:45:27 +0000 (UTC) In-Reply-To: <83wnepmy7q.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 13 May 2022 15:08:41 +0300") X-Mailer: WebService/1.1.20188 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.188.204; envelope-from=luangruo@yahoo.com; helo=sonic311-23.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:289729 Archived-At: Eli Zaretskii writes: > If we come up with a safe enough fix, we could consider backporting it > to the release branch. I think the display issue is not serious enough to backport (and probably can't be fixed safely). But the tooltip face overwriting the text completely prevents any meaningful use of `mouse-drag-and-drop-region'. This is enough to fix that bug alone: diff --git a/lisp/mouse.el b/lisp/mouse.el index 1b9542b9b8..e5ea5475f4 100644 --- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -3049,7 +3049,7 @@ mouse-drag-and-drop-region ;; Show a tooltip. (if mouse-drag-and-drop-region-show-tooltip - (tooltip-show text-tooltip) + (tooltip-show (copy-sequence text-tooltip)) (tooltip-hide)) ;; Show cursor and highlight the original region. WDYT?