unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: master 977f3f27c5 2/2: Don't issue warnings for Unicode quotes for now
Date: Mon, 06 Jun 2022 14:22:43 +0200	[thread overview]
Message-ID: <874k0yyoa4.fsf@gnus.org> (raw)
In-Reply-To: <CADwFkmktEMML=qX9gi1Mdgz9VQUFc8EHNR7H6zwWvSmZk01qrQ@mail.gmail.com> (Stefan Kangas's message of "Sat, 4 Jun 2022 23:04:41 +0200")

Stefan Kangas <stefan@marxist.se> writes:

> I was thinking of making it depend on a separate variable or user
> option that we would set as a directory local variable.  Could such an
> approach work?

Yes.  But it feels a bit awkward to introduce a variable just for this.

We do have byte-compile-warnings, which can be either t or a list, and
it would be nice if we could extend that to cover this use case, to
avoid introducing another mechanism.  But we want t to mean
"everything-but-this"...  Hm...

Perhaps we could make an explicit mapping: t to `(not
(docstrings-unicode-quotes ...))' and then introduce a new `emacs-build'
value that's the old t (basically)?  That way we could (in the future)
introduce more warnings just for the Emacs build that wouldn't affect
other usages of the byte compiler.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2022-06-06 12:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165425457951.24295.4901777157797017566@vcs2.savannah.gnu.org>
     [not found] ` <20220603110939.F1B93C06564@vcs2.savannah.gnu.org>
2022-06-03 12:19   ` master 977f3f27c5 2/2: Don't issue warnings for Unicode quotes for now Stefan Kangas
2022-06-04 11:26     ` Lars Ingebrigtsen
2022-06-04 21:04       ` Stefan Kangas
2022-06-06 12:22         ` Lars Ingebrigtsen [this message]
2022-06-18 14:39           ` Stefan Kangas
2022-06-19 11:37             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874k0yyoa4.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).