unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master ed84f24a21: Make `signal-process' allow completing over signal names
Date: Mon, 27 Jun 2022 08:56:01 +0200	[thread overview]
Message-ID: <874k06a932.fsf@gnus.org> (raw)
In-Reply-To: <87a69yegza.fsf@yahoo.com> (Po Lu's message of "Mon, 27 Jun 2022 14:51:53 +0800")

Po Lu <luangruo@yahoo.com> writes:

>> I just punt to gnulib.  Presumably it gets all this right, and if not,
>> it's a bug in gnulib.
>
> gnulib doesn't specify the largest signal number to be 255, right?

Oh, you mean the loop ends one too early?  Yes, that's true.  Can't have
new code without at least one off-by-one error; that's illegal.

>> (I guess there are systems with on OS sig2str, too, but the same
>> applies there.)
>
> They don't exist, AFAICT sig2str is a gnulib extension.

That was my original assumption, but we apparently check the OS for
sig2str via autoconf, I discovered yesterday.  config.h:

/* Define to 1 if you have the `sig2str' function. */
/* #undef HAVE_SIG2STR */


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2022-06-27  6:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165627647702.21409.11158107897633930882@vcs2.savannah.gnu.org>
     [not found] ` <20220626204757.57AB1C01685@vcs2.savannah.gnu.org>
2022-06-27  1:20   ` master ed84f24a21: Make `signal-process' allow completing over signal names Po Lu
2022-06-27  6:37     ` Lars Ingebrigtsen
2022-06-27  6:51       ` Po Lu
2022-06-27  6:56         ` Lars Ingebrigtsen [this message]
2022-06-27  7:04           ` Po Lu
2022-06-27  7:10             ` Lars Ingebrigtsen
2022-06-27  8:10               ` Po Lu
2022-06-27  8:12                 ` Lars Ingebrigtsen
2022-06-27  8:25                   ` Po Lu
2022-06-27  8:47     ` Daniel Martín
2022-06-27 10:55       ` Lars Ingebrigtsen
2022-06-27 11:36     ` Eli Zaretskii
2022-06-28 11:23       ` Lars Ingebrigtsen
2022-06-28 13:19         ` Po Lu
2022-06-28 13:25           ` Lars Ingebrigtsen
2022-06-28 13:28             ` Po Lu
2022-06-28 13:32               ` Lars Ingebrigtsen
2022-06-28 13:34                 ` Lars Ingebrigtsen
2022-06-28 13:35                 ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874k06a932.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).