From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Thu, 01 Sep 2022 15:26:43 +0200 Message-ID: <874jxrgr8s.fsf@gmail.com> References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> <877d2pnqup.fsf@yahoo.com> <86zgfknc9a.fsf@mail.linkov.net> <87sflc91q7.fsf@gnus.org> <87wnao7l74.fsf@gnus.org> <0d5679a1-7635-53db-51c7-0ac0e35325d8@yandex.ru> <87mtbke7wf.fsf@gnus.org> <87ilm8e5am.fsf@gnus.org> <87k06nz9g8.fsf@gnus.org> <874jxrz5ai.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4457"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , Juri Linkov , Po Lu , "Alfred M. Szmidt" , eliz@gnu.org, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 01 15:50:47 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTkak-0000uO-4F for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Sep 2022 15:50:46 +0200 Original-Received: from localhost ([::1]:52346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTkaj-0005aK-6U for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Sep 2022 09:50:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTkDZ-0007rF-F1 for emacs-devel@gnu.org; Thu, 01 Sep 2022 09:26:49 -0400 Original-Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:45679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oTkDX-0003jE-UZ; Thu, 01 Sep 2022 09:26:49 -0400 Original-Received: by mail-wr1-x433.google.com with SMTP id w5so6185289wrn.12; Thu, 01 Sep 2022 06:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:gmane-reply-to-list:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=xw98AQMbQMMMjun3GBiJ6YhgjIqQ35ef5ffmI4Vzq6Y=; b=OEFYs+JP4PxkYZl5PaYDxpF/vWcSVUvc6Pv+K8GRDIbC5KfA8Gaq/B5cKy0qz8qpny pXE+/ChhixHMkcMG91ir71/STclfq9c1w20JTKsuTxcTDxCAT6bu71LInePTrNxboiS+ dSgoxeSsuKLXj7iF7TU10EWWaOqGcZtb2YB0gLrwrF8gitmiMNVk6fJFKBB76POxliZz dzwHaqHQXm1xOrAGwPZwnJgFJkRrW9X1BMJXXyWkqRXCqbzWXqhN7ktgVzl5fS3sEYKt WErFkENa4j6H0wcyvvQDFk8rD8wBRo4ii1z2rj4qLibxiLJUDAB46jLBzb7p+BZKQ0cH yOcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:gmane-reply-to-list:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=xw98AQMbQMMMjun3GBiJ6YhgjIqQ35ef5ffmI4Vzq6Y=; b=drURUpYxUpVzMb21ii39xVh+5WARz48XTUY/f80vOVBOPrCQH1oJKN4muDryC2NFh3 zpJpqkvcuafyMXYZQ0upN93dTG0aXGsgzlzqaw2ziwLGbsCCWQl04NnUsNQVmg85h7Zt AYXNt9rSJzITzmJOxcUXDvHR6Lwj47aWClt9LoRp3kxh1UTfy1qZ77o83dWkMpzXoztk zIUBsG0tJIlhT4H42rZrKQ56vQbMafKDbiIJ3pPk/3ftdw+a5XQ6hJXXZgWDlxC43thv CcJFifjoOzUKtUbOfUWjjv/F3w9zlb4ooIZ94GJNVtB4+9PdlWgoLKmufPt27rVfdygb ysHA== X-Gm-Message-State: ACgBeo3yeEMzuO0ocMTqXhxN7mmxGBHU39IaDmITufAtNUWteT4UsWV/ j9TErB7pCnaX5V444epVfEzJdMdaIkc= X-Google-Smtp-Source: AA6agR6Pf0JSsSSlNRayXT1aFDKwGVnuiIJhpsG6WQ1WQvkea0HZbYoul0I18Jda5q7UE5yfg356FA== X-Received: by 2002:a05:6000:381:b0:221:7507:bb24 with SMTP id u1-20020a056000038100b002217507bb24mr15328079wrf.373.1662038805138; Thu, 01 Sep 2022 06:26:45 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:34fb:6aed:1aac:5cee]) by smtp.gmail.com with ESMTPSA id l6-20020a05600c4f0600b003a607e395ebsm6580661wmq.9.2022.09.01.06.26.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Sep 2022 06:26:44 -0700 (PDT) In-Reply-To: <874jxrz5ai.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 01 Sep 2022 13:45:57 +0200") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=rpluim@gmail.com; helo=mail-wr1-x433.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, GAPPY_SUBJECT=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294483 Archived-At: >>>>> On Thu, 01 Sep 2022 13:45:57 +0200, Lars Ingebrigtsen said: Lars> Dmitry Gutov writes: >> The step of "applying the saved patch" relies on our Lisp code being >> correct and being able to handle any diff. It's not an outrageous >> assumption, but an assumption nevertheless. Lars> Oh, I was assuming that we were assuming that we had "patch" installed Lars> for this to work. I don't think that's unreasonable for new Lars> functionality like this. 'git apply' will work as a replacement for 'patch' as well. Robert --