From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Making `eglot-server-programs' a custom variable? Date: Thu, 10 Nov 2022 19:36:54 +0000 Message-ID: <874jv67ga1.fsf@posteo.net> References: <86fservpri.fsf@gnu.org> <87cz9v97lo.fsf@posteo.net> <86r0yb234t.fsf@gnu.org> <87o7te7lc7.fsf@posteo.net> <87k0427k9i.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27997"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Arash Esbati , emacs-devel , =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 10 20:37:44 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otDMu-000752-AR for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Nov 2022 20:37:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otDMF-0007k5-U7; Thu, 10 Nov 2022 14:37:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otDME-0007jt-BA for emacs-devel@gnu.org; Thu, 10 Nov 2022 14:37:02 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otDMC-0000Cx-Ib for emacs-devel@gnu.org; Thu, 10 Nov 2022 14:37:02 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 9745E240106 for ; Thu, 10 Nov 2022 20:36:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668109017; bh=wZcbaeN+ZpkF5r2DPgNSESHl8Ep+0jKgnGfbd5fUMGY=; h=From:To:Cc:Subject:Date:From; b=Bhqk790mpJVb+z4cRsVCix5GGR7/q6BXggwVGg2kt+ECexlHX4/QaqGr1U4f7keKX USeaOsh5Bk0MHKxLhfysbOL19PyQUIWoSrTYo6exIoVpfKe68yYwgxHRO0HayZPuoH 7vNs7KpBRslbkbAPsD9NsdnqXmYU5l5Fa0zBvGvexo0Hfh5OTt/aGCXhT4KBenK5pN z1QlQsjYO6aCDrmB2arvXyClKsZxtZGYzTF7m5IxHRCRf1cBXGPKUKtCFPGSY5EC7h bN1uHNRZ/qMR79Cf9uRnM4iQyUzG45B+foxoXNgTt9TI1j9QpesA+yRjexQNNUepXx 19ei2055/sq8A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N7XCV2V0fz6tmP; Thu, 10 Nov 2022 20:36:54 +0100 (CET) In-Reply-To: (Stefan Monnier's message of "Thu, 10 Nov 2022 13:29:06 -0500") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299519 Archived-At: Stefan Monnier writes: >>> I suspect it would not be able to use `with-eval-after-load` because it >>> wouldn't know which file holds/defines that var. But we could make it >>> work for Custom vars, OTOH. >> >> I have the hunch that modifying `add-to-list' along these lines could >> break a lot of subtle programs, > > I'd imagine the change would only affect the case where the var is > unbound, i.e. where we currently signal an error. For that reason, it > seems safe enough. If that is all the function does, I think it should be safe. Other questions are if an error should be raised when there is a type-mismatch or if the custom setter/getter ought to be used.