From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Utilize new font-lock faces for C/C++ and Python tree-sitter use Date: Tue, 15 Nov 2022 11:25:18 +0100 Message-ID: <874jv0v7jl.fsf@thornhill.no> References: <87h6z1l4ve.fsf@thornhill.no> <9T55ZBXi9h5N4O9RqM4jvYMI2VgkGFWfTHQ5T8gS-_JD95YP04nzWFULyXHYhi86D8AtCw6cXvPw5bHZrTA-2l45yGwY1gFT61A2tLrhVok=@rjt.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2993"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu , emacs-devel@gnu.org To: Randy Taylor Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 15 11:26:31 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1out9D-0000bu-IB for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Nov 2022 11:26:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1out8Z-000556-2H; Tue, 15 Nov 2022 05:25:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1out8D-00053F-1f for emacs-devel@gnu.org; Tue, 15 Nov 2022 05:25:30 -0500 Original-Received: from out2.migadu.com ([188.165.223.204]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1out8A-0000WP-T2 for emacs-devel@gnu.org; Tue, 15 Nov 2022 05:25:28 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1668507920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y3chWJWtqwYcLBnngqxQBuSAJU4iFbIjO16oftmLiak=; b=tl57YDrsPKsSTlIXelJkI07PsQ9/f7QJ3UsO0F4bGjLAqNvA8z5RUVM8DinfbB3IwYMeEk SALSJKD43YM9DTWf+quR/UcHbw1xDAiukkHf4didbxl8Njlm4NpeVfSsAZeasOvlERWYoK UpxXSxEgg3MSHS00pGrNlM3v29nT76AhoDuSdMeXcn6hmWRs2x/U8dNDpHRr98PsNIJuTS 9g3mFlnq4GquvjXz97eicDioY7aNuJXsi10n6BvCa32dvtLj0SNK4NJg7CdjXMe12i/mA3 Z4ZavD3sN87okCuOkNcTItiWlVsKbbg5o8VLpVh4Brzm3UVq81PnfSvukS1P+A== In-Reply-To: <9T55ZBXi9h5N4O9RqM4jvYMI2VgkGFWfTHQ5T8gS-_JD95YP04nzWFULyXHYhi86D8AtCw6cXvPw5bHZrTA-2l45yGwY1gFT61A2tLrhVok=@rjt.dev> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=188.165.223.204; envelope-from=theo@thornhill.no; helo=out2.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299838 Archived-At: Randy Taylor writes: > Looks like my bug finally got created (Bug#59268) so we can continue the discussion there. > Thumbs up. > Will reply to what's been said so far below. > > > On Monday, November 14th, 2022 at 14:20, Theodor Thornhill wrote: >> >> Are you sure we cover most of the stuff that was covered in the old >> style? I see it is different visually, but that's likely the new faces >> are without any color, right? > > I think so, at least I don't notice anything wrong (the old style was actually missing some things). > Indeed, most of the new faces are without any colour. Property and escape-sequence are the only ones > that have any, and they inherit. > > Do you have any specific examples? > Nope, I think it's fine. Just wanted to ask :-) >> >> I think you should add similar changes to all the new modes: >> >> - ts-mode >> - json-ts-mode >> - css-ts-mode >> - java-ts-mode >> - js-mode >> >> If you have time and energy, of course :-) >> > > I plan to. Hopefully this week and weekend. -- Theo