From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: Warn about comparing quoted lists (etc) using `eq` Date: Thu, 15 Dec 2022 10:50:37 +0000 Message-ID: <874jtxueiq.fsf@localhost> References: <8D624413-5A6C-46D7-A4EB-53C23F7CC4D3@gmail.com> <58A7E984-95CC-4F7F-817B-10E680E5966E@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18735"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Juanma Barranquero , emacs-devel , "Dr. Arne Babenhauserheide" To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 15 11:51:02 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5lpN-0004c1-5z for ged-emacs-devel@m.gmane-mx.org; Thu, 15 Dec 2022 11:51:01 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5lp8-0000Wv-96; Thu, 15 Dec 2022 05:50:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5lp4-0000Wa-DR for emacs-devel@gnu.org; Thu, 15 Dec 2022 05:50:42 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5lp2-00060Z-JA for emacs-devel@gnu.org; Thu, 15 Dec 2022 05:50:42 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5C152240104 for ; Thu, 15 Dec 2022 11:50:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1671101439; bh=w076BIL48vj2MFOnYiFdesLpSkIIhbb5XygksoGV73A=; h=From:To:Cc:Subject:Date:From; b=VWGO/ZsiFv29/UeAAfM9CtM02q4/YRjbwCMhNWYY32LHEHe6ZZiWPS6aLX/SeZyvQ byCDmv6oJjruP0tHC6j31s68nlcYW5z5SRI1PfZp47XRyGrUZ8XGPx6TyitmXVH4MG KQdRbNOkjkjNrZQV7E0a4jBKc9FeFdV3ZctOioFW24MI7J+B0wWH2XyEzM2wn0Iglc xteIwWu4fpDcJsZBXrnznwHTtX+QPrr3dY2gPPqzcAdLXTT3M/GrSd8Xu72gWqBff8 nRd8Un49eF/1LoYgmmezDYtMFj4ekIVxmGh2d9AyHHQk8d/DczfmyCY4hMPE8foZ0a BKaitBmrr8KBw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NXpt63sBSz9rxR; Thu, 15 Dec 2022 11:50:38 +0100 (CET) In-Reply-To: <58A7E984-95CC-4F7F-817B-10E680E5966E@gmail.com> Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301453 Archived-At: Mattias Engdeg=C3=A5rd writes: > While this sounds like a useful suggestion on the surface, it's actually = slightly dangerous: blindly replacing `eq` with `equal` (and `memq` with `m= ember`, and so on) may very well break working code (that silently relied o= n the condition not being true). It's also a poor remedy against pratfalls = like > > (memq x '(one 'two 'three)) > > which do occur. What we really want is to make a human look at the code, = and think. Then, there should also be a way to tell the compiler not to throw the warning in specific, checked, places in the code. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at