From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, juri@linkov.net
Subject: Re: emacs-29 4a8891a462: * etc/NEWS: Mention incompatible changes in 'outline-minor-mode-cycle-map'.
Date: Mon, 16 Jan 2023 18:18:47 +0100 [thread overview]
Message-ID: <874jsqe6tk.fsf@gmail.com> (raw)
In-Reply-To: <83bkmy4dru.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 16 Jan 2023 18:58:45 +0200")
>>>>> On Mon, 16 Jan 2023 18:58:45 +0200, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: emacs-devel@gnu.org, juri@linkov.net
>> Date: Mon, 16 Jan 2023 16:02:38 +0100
>>
>> >> Juri/Eli, any objection to putting something like the following in
>> >> emacs-29? That would make it easier to add heading-specific bindings
>> >> in NEWS mode, which Iʼd do in master. It also avoids creating a
>> >> separate keymap for each heading.
>>
Eli> I don't think I understand the problem you are trying to solve, and
Eli> why this particular solution. Please tell more.
>>
>> In outline-mode and modes derived from it, there are various bindings
>> that work at the start of headings (and in buttons that could be
>> inserted depending on the value of `outline-minor-mode-use-buttonsʼ),
>> such as "RET" for `outline-cycle'.
>>
>> Adding more bindings there is a pain, since the bindings are done
>> using a separate anonymous keymap on each per-heading overlay, which
>> means iterating over all the overlays in order to make changes. The
>> patch I sent changes that to use a named keymap, so only the named
>> keymap needs to be updated or `setq-local'ʼd before invoking
>> `outline-mode'.
Eli> Ah, okay. Fine with me if Juri (or someone else) doesn't object.
>> (and what I really want to do is add 'n' and 'p' into that map, which
>> improves the speed at which I can proofread NEWS.)
Eli> On master or emacs-29?
On master. Iʼm assuming adding bindings would not fall under 'bug
fixes only'.
Robert
--
next prev parent reply other threads:[~2023-01-16 17:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167346587385.21119.11842722402918987249@vcs2.savannah.gnu.org>
[not found] ` <20230111193754.33EF3C00A7F@vcs2.savannah.gnu.org>
2023-01-16 13:57 ` emacs-29 4a8891a462: * etc/NEWS: Mention incompatible changes in 'outline-minor-mode-cycle-map' Robert Pluim
2023-01-16 14:33 ` Eli Zaretskii
2023-01-16 15:02 ` Robert Pluim
2023-01-16 16:58 ` Eli Zaretskii
2023-01-16 17:18 ` Robert Pluim [this message]
2023-01-16 17:43 ` Juri Linkov
2023-01-16 18:26 ` Eli Zaretskii
2023-01-16 19:02 ` Robert Pluim
2023-01-16 19:37 ` Eli Zaretskii
2023-01-30 14:39 ` News-mode improvements Robert Pluim
2023-01-30 14:58 ` Eli Zaretskii
2023-01-30 15:14 ` Robert Pluim
2023-01-17 7:29 ` emacs-29 4a8891a462: * etc/NEWS: Mention incompatible changes in 'outline-minor-mode-cycle-map' Juri Linkov
2023-01-17 8:52 ` Robert Pluim
2023-01-17 17:25 ` Juri Linkov
2023-01-18 8:30 ` Robert Pluim
2023-01-24 18:38 ` Juri Linkov
2023-01-24 22:03 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jsqe6tk.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).