From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Extending timeclock.el Date: Sat, 06 May 2023 06:09:17 +0000 Message-ID: <874joqrnxu.fsf@posteo.net> References: <861qjubmzp.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22667"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: John Task Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 06 08:10:13 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvB7U-0005fz-3Q for ged-emacs-devel@m.gmane-mx.org; Sat, 06 May 2023 08:10:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvB6k-0004n7-V3; Sat, 06 May 2023 02:09:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvB6i-0004li-1e for emacs-devel@gnu.org; Sat, 06 May 2023 02:09:25 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvB6f-0007bG-TG for emacs-devel@gnu.org; Sat, 06 May 2023 02:09:23 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D32A2240EE7 for ; Sat, 6 May 2023 08:09:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683353358; bh=LM9aIZib3rqHHIpXVEnuXUNnXgUeTu6aMtooVyJBTY0=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=TcdPNc8VXrBB5+/jFg1lBwgDt1kerGl7X+DkbOVyDmdNIgerMW5nHYtXasazWitoE ZAz5tbm9yzAxc7F5KI9qde50sfitsjqfKys6cpbkZNGPsmYr3AGM/11lDn12Idl8jH UXAhtbNs8wNUlZXRS+Cyu9T6qQXNKchD7TMxDUWKIHTPY6cX+QTw4oCLdht7qaLyrz udrtN5sYRAtG61ZDifmPn77EPm6pmPcGuv1wBghzpuiABVLwBmqzy1lTE00mgIrDNo yAx1lhd42uh8XwWLqmJAiUuyoAPr4N4qiEOrQxNraMKUs7DN3v6Y3avMO4eLAMZTEB LLOURWdT8cPZA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QCxvy2s1wz6tn4; Sat, 6 May 2023 08:09:18 +0200 (CEST) In-Reply-To: <861qjubmzp.fsf@disroot.org> (John Task's message of "Fri, 05 May 2023 16:15:02 -0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305891 Archived-At: John Task writes: > Hello. A little context, first; some days ago, I submitted a request > for including a package in the NonGNU ELPA repository. The package in > question was a time tracker named ETT. However, Eli pointed out that > instead of creating a new package I could, for instance, extend the > built-in timeclock.el instead. To be honest, I didn't like the idea > at first, but looking at the code I quickly realized it wouldn't be > that hard. At least, not as dramatically hard as I thought. > > So I started this: https://gitlab.com/q01_code/timeclock-modern > > [This wasn't my first name choice, but turns out timeclock-x is > already taken] By whom? I couldn't find anything. > So far, I managed to write a series of parsers for the timelog format, > as well as a basic API for retrieving information from it. This > should allow me to port all the relevant code from ETT without issues. > However, I'm not really familiarized with timeclock, so I can't assert > my design choices so far have been ideal. > > + The letter code at the start of every line was the most difficult > part. ETT (and a lot of modern time trackers as well) don't > understand what clock-out means, as the idea is to clock everything; > the user just clocks-in different activities. So, I dropped 'i' and > 'o' for my custom tm-clock-in altogether. As for the parser, it > understands 'o' as the start of a so-named 'Untracked' item/project. > That way it can read existent timelogs just fine. This is hard > enough, but turns out there are also other codes ('h', 'b' and '0'). > I interpret '0' as an 'o' and ignore the other ones, but I'm not sure > if this is correct. > > + As I make a lot of decisions such as the last one from ignorance, > I'm clueless about how well the parser (and the API) works for real > timelog files. If anybody wants to test that, it would be > appreciated. > > + As the original timeclock-in doesn't support inputting tags (as well > as other features I need), I wrote a custom tm-clock-in. But I'm not > sure if this is the right approach. And redefining timeclock-in would > be even worse, for sure. > > I'll eventually contact the original author as well, but I wanted to > know of any other opinions here first. > > Best regards. -- Philip Kaludercic