From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 1b64ed6d6a6: * lisp/misc.el (duplicate-line-final-position): New defcustom (bug#64185). Date: Fri, 30 Jun 2023 11:32:09 +0200 Message-ID: <874jmpgusm.fsf@gmx.de> References: <168802306502.18770.6910423069706438994@vcs2.savannah.gnu.org> <20230629071745.70945C19274@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8865"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Juri Linkov To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 30 11:33:17 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qFAVA-00028p-Ma for ged-emacs-devel@m.gmane-mx.org; Fri, 30 Jun 2023 11:33:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qFAUJ-00059R-6q; Fri, 30 Jun 2023 05:32:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFAUE-00058p-5P for emacs-devel@gnu.org; Fri, 30 Jun 2023 05:32:19 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFAUC-0001Nm-98 for emacs-devel@gnu.org; Fri, 30 Jun 2023 05:32:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1688117531; x=1688722331; i=michael.albinus@gmx.de; bh=dOPd9JdF7+yXbDs+dIawRs2KWPsvPrhkXqcfgLXGsag=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=VSpyzyIJ9MiuqpYZEg0TrgjFvRI5tVorckKa3tQFEDmw3+YuLX5d6wydN5M4+N2TfxcKE+8 7pWAzZTwfeREvDYAOVIzObYFOyUUbMR0MUNabQV69lvHYaviLYmINV5CrBs83WSxWyE9XjAf2 e+AF23OnXAxIYqsKmDGebgRCB12oqqWxs07PAUJzU5M9ngx15wwNP7UOTcbP91VCZ8rJ1hYEO 68Why0f+IjAE9zbOL0z8vPowk9IJbrWq8/SeGQo6fuQb6+m4/Y0jGbKyd1SOEkbFjbu7D3nu3 XJxvJzcVcZ/JPdHjh1OfAH1pyVsNdUFE3ELtYoa+AhtYl+JggjLA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.13]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M2wL0-1qBshC0Rhs-003Nht; Fri, 30 Jun 2023 11:32:10 +0200 In-Reply-To: <20230629071745.70945C19274@vcs2.savannah.gnu.org> (Juri Linkov's message of "Thu, 29 Jun 2023 03:17:45 -0400 (EDT)") X-Provags-ID: V03:K1:cBwzzkuWOKzmvoX3bNxkr8jlbOEgvLmKUTYiH31grT780pZiWyF bL046llIXkpcZevj9Gb7TOThzmyjtsN87Cj9i2PsD7ay/hqha+uG7LbX2uc+T4sNxOe/wSv uYnPCY5b2LlumHCmHxfyJGFPEB5N8G8CekU9zAuy62p/YcaFGEDHxGuu330yoj0aT1VduvZ JEUcntcRTRQSF1h1W6oLA== UI-OutboundReport: notjunk:1;M01:P0:FY4HWDrDPyc=;CaCks5kJmRVqKDidA1R+2P3mg6N VfwpBTVqoW1IUDps8rPLx2sGHaqUSJOZL58AzeBK/mtiufHHr27E7Tsr1stUbJjCQbKit3Sgw oTNzlj8jIXIw1qfqCzPx66lv4qmCerpBjHGpLdIWiu1TiweOlKfrsQ+L15d3Aa8F83QCy/V52 l6ADbUJgK0Y1wynxPu1UxYxUlj2a72eJVLeAEclnBoXMxYNKejuvtjOg3TsXs1/lsQ82ujbGF yYynBoQmZlhuFdVi6buovHC5FbU7dBnKrTbplop7EkbrFit6Yfmj0c+T7gXTEgzeSQKbkA6yn SXda8HngUPXE00iTXOoRC4WETYEnZgejfp35iYPamIm00yara9Q46kytLBqSnlulHcLZt7il8 dY+1E56pbUG42Ouig/IZRYtccXN7w+aWyLz0U6azxR+1eJtLiKd/VOxTtl2x4A9dscHOHWwfW 0ak0eO6clV5LaB0WU73Fp3VoB2EE06s9DGvNHW959aUtXlTRNOQ+qo9nk7JPwS+LEPgutbKBp nr6jlHqLi83jLeCgkqSsVkgu6RV4etXWqRrsrS+X2yLHH1wqZf0dNXlv8ol9ZSSTzfNcUuhVy xodE1WpE7POwy9hMPSzpg+AzI/I3Uezj8Dddrb6fKKodG2TJBCOp0jX7ENIkpK/jFgLIdRGTc qJE1j6xeytC0oyWzpmTcgaeodrAVesCAlHinsTd+JjeEk3b1dbU/eYF0m/uIuW7pw4rEexW+B 97OizQls4wlO5TGGPlLgQI7J5Tjwl6P1SML2Us1Gqd9NVzsy/TalXvBpeK9BshxeNFlqH1pT Received-SPF: pass client-ip=212.227.15.18; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:307312 Archived-At: Juri Linkov writes: Hi, > * lisp/misc.el (duplicate-line-final-position): New defcustom (bug#6= 4185). > > * lisp/misc.el (duplicate-line): Use it. > > * test/lisp/misc-tests.el (misc--duplicate-line): Add tests for > duplicate-line-final-position. When running the tests with native compilation, there's an error: =2D-8<---------------cut here---------------start------------->8--- ELC+ELN lisp/misc-tests.elc In toplevel form: lisp/misc-tests.el:95:12: Warning: Unused lexical variable `duplicate-line= -final-position' lisp/misc-tests.el:102:12: Warning: Unused lexical variable `duplicate-lin= e-final-position' GEN lisp/misc-tests.log Running 7 tests (2023-06-29 18:20:46+0000, selector `(not (tag :unstable))= ') Mark set (rectangle mode) passed 1/7 misc--duplicate-dwim (3.970630 sec) Test misc--duplicate-line backtrace: signal(ert-test-failed (((should (equal (point) 12)) :form (equal 7 ert-fail(((should (equal (point) 12)) :form (equal 7 12) :value nil #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name misc--duplicate-line :documentation n ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :unstable)) ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type ert-run-tests-batch((not (tag :unstable))) ert-run-tests-batch-and-exit((not (tag :unstable))) command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/misc-tests" "--eval" command-line() normal-top-level() Test misc--duplicate-line condition: (ert-test-failed ((should (equal (point) 12)) :form (equal 7 12) :value nil :explanation (different-atoms (7 "#x7" "?\7") (12 "#xc" "?\f")))) FAILED 2/7 misc--duplicate-line (0.000560 sec) at lisp/misc-tests.el:= 83 passed 3/7 misc-test-backward-to-word (0.000207 sec) passed 4/7 misc-test-copy-from-above-command (0.000132 sec) passed 5/7 misc-test-forward-to-word (0.000131 sec) passed 6/7 misc-test-upcase-char (0.000114 sec) passed 7/7 misc-test-zap-up-to-char (0.000278 sec) Ran 7 tests, 6 results as expected, 1 unexpected (2023-06-29 18:20:50+0000= , 4.174909 sec) 1 unexpected results: FAILED misc--duplicate-line ((should (equal (point) 12)) :form (equal= 7 12) :value nil :explanation (different-atoms (7 "#x7" "?=07") (12 "#xc"= "?\f"))) =2D-8<---------------cut here---------------end--------------->8--- See for example . Running the tests w/o native compilation don't show that error. Best regards, Michael.