From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: master 5892b4db8de 2/3: Convert dictionary-mode to define-derived-mode Date: Thu, 17 Aug 2023 11:15:57 +0200 Message-ID: <874jkyvxki.fsf@epfl.ch> References: <169185199333.11628.2162615922937919004@vcs2.savannah.gnu.org> <20230812145313.C853CC038C2@vcs2.savannah.gnu.org> <871qg3404x.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15898"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, Stefan Kangas To: Visuwesh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 17 11:17:05 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qWZ7p-0003vZ-1C for ged-emacs-devel@m.gmane-mx.org; Thu, 17 Aug 2023 11:17:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWZ75-0002jF-T2; Thu, 17 Aug 2023 05:16:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWZ6x-0002it-Q6 for emacs-devel@gnu.org; Thu, 17 Aug 2023 05:16:12 -0400 Original-Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qWZ6t-00029s-G4 for emacs-devel@gnu.org; Thu, 17 Aug 2023 05:16:10 -0400 Original-Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-3fe4a89e7efso68278595e9.3 for ; Thu, 17 Aug 2023 02:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1692263760; x=1692868560; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ncj/UMRCRCb/U1kTGh24NSe8MmakVfVt29m/oo40y4A=; b=NwzHObfaWwp1jHmxWeZo1HSrHxF7DfsaQl675BXG5EpISndqoL0mXwcciH6ep9pqy0 Q2DotYhnicmxpkOkpWqHFc/QIePQAGNePVOsPdpCoeAj+MkKGiZ49UnfkuDCuoMwjsWu g+vAPa5EbT3qFJ45zzMUwgPBIup5w7yczUbWYll1XiCztNNySkElQHjhAP74dINizrEn QXKccNuPxEiqih4M04rULDZw9QTM5p7i/DV6YcUKShCiG0+WR0OLGKfp7YEH+s4/ejrx ViD3cbsFrCr2tHUoM8NJTamu28IKCSdctAy0rD1ZPcpV8ooAEgihBMvE5wKupjAVuC9O gBHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692263760; x=1692868560; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ncj/UMRCRCb/U1kTGh24NSe8MmakVfVt29m/oo40y4A=; b=FYFVf1OeBa+U/Ilhqgme3NxlEI69QcPsuN84pPItz1UumiCLYGXZ6OdfQHxVgPF9rM 1sSvFcTxEAYBoMoO9Km7hcXWCE8dRWVR3MiXbWxsqulMoX4zUVwza2W9gLabfILaE/Zc LlABVyNMSC9G4rhYQP71t6hFf8oIrw7ymmpcFhvPFaZykJzECVAh+9JVzufGxL63Szl2 GnOQPEdr2sz0LXFz5ouIupg0bWcCtJNiUqkVp5BwNZQx9mTljbHaj1uv+UOEJg9QntO3 OPwCvye7iQPEDH807DyIMMuhMy0ooW+UH3YPCcWKeIvwdwUbmgH6KobqSNqZMH82Djd5 EWNQ== X-Gm-Message-State: AOJu0Yzzg9ioKvAdxBbjG4daHjz+pywDjJ8rEb95PnPVlaVx0AKS37rB +u6NfKu8tbqnDxbmZS7JzN5n/g== X-Google-Smtp-Source: AGHT+IHCPLAT1U0Ws9ycTskAr8rp0+ybs0iOm+JLMIdkwoaEAP/GRdaWLaa8OETeiWeU86z/a/vVPQ== X-Received: by 2002:a7b:ce95:0:b0:3f7:678c:74b0 with SMTP id q21-20020a7bce95000000b003f7678c74b0mr3386218wmj.12.1692263760134; Thu, 17 Aug 2023 02:16:00 -0700 (PDT) Original-Received: from localhost (netacc-gpn-4-46-194.pool.yettel.hu. [84.224.46.194]) by smtp.gmail.com with ESMTPSA id z15-20020a05600c220f00b003fe26244858sm2176440wml.46.2023.08.17.02.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Aug 2023 02:15:59 -0700 (PDT) In-Reply-To: <871qg3404x.fsf@gmail.com> (Visuwesh's message of "Wed, 16 Aug 2023 18:25:42 +0530") Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=contovob@tcd.ie; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308852 Archived-At: Visuwesh [2023-08-16 18:25 +0530] wrote: > [=E0=AE=9A=E0=AE=A9=E0=AE=BF =E0=AE=86=E0=AE=95=E0=AE=B8=E0=AF=8D=E0=AE= =9F=E0=AF=8D 12, 2023] Stefan Kangas wrote: > >> branch: master >> commit 5892b4db8de4694904f631dd86438926fb9d7ff1 >> Author: Stefan Kangas >> Commit: Stefan Kangas >> >> + (seq-reduce #'+ >> + (mapcar >> + (lambda (buf) >> + (with-current-buffer buf >> + (if (derived-mode-p 'dictionary-mode) 1 0))) >> + (buffer-list)) >> + 0)) >> + > > I believe the following function should be faster > > (defun dictionary--count-mode-buffers () > "Return the number of buffers that " > (seq-reduce (lambda (count buf) > (if (provided-mode-derived-p (buffer-local-value 'maj= or-mode buf) > 'dictionary-mode) > (+ count 1) > count)) > (buffer-list) > 0)) Yet faster and simpler would be to use seq-count in place of seq-reduce. Thanks, --=20 Basil