From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: man broken? Date: Sun, 07 Jan 2024 12:48:26 +0100 Message-ID: <874jfpfjp1.fsf@gmx.de> References: <87y1dfiidg.fsf@gmx.de> <87y1delksf.fsf@posteo.net> <87jzoyi9fa.fsf@gmx.de> <87plyothk9.fsf@gmail.com> <87wmsvudji.fsf@gmx.de> <871qaybett.fsf@posteo.net> <87v88aa04w.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37393"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Visuwesh , "T.V Raman" , emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 07 12:49:18 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rMReY-0009Zg-Ok for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Jan 2024 12:49:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMRdr-0007rK-Po; Sun, 07 Jan 2024 06:48:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMRdp-0007pf-NQ for emacs-devel@gnu.org; Sun, 07 Jan 2024 06:48:33 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMRdn-0002o8-V7 for emacs-devel@gnu.org; Sun, 07 Jan 2024 06:48:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1704628107; x=1705232907; i=michael.albinus@gmx.de; bh=1cxw1VWkvv2u3rAlajwA26MjmG8DpA0p0doSX3jR6vA=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=bFcgC3vyseQ45Bf5My0cmIA8+BMcHx+mErgwbT/kDUEbY8y5bzMi+VyaaJ54kqBU f73xUGMirTTSDSJL7z51OJ/3+PwpVIKxmHmrEI6ioUmXJnExJRokT7qT/6Mf8cut/ ZtJ51Yr/uKpHgxaqxLYcl1Qktn92fuGKcnoQYqfTKuq7TPJVnSuneY1KRkziDxZoC D5o3xUgBrTlL9GEeTeZwOnCVnflqP3HQ14py+K/0i/GQo01qd4GllpKoAUa7i0tEy QtLzm2A0DV0F7VlS29EyoZMlRTpNikQgNPpS1pYzYGtsxenjcxR/ZWPN4gzc95OdZ GoHcKku4KVKKJmL3SA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.3]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MgeoI-1qhc752UHM-00h85L; Sun, 07 Jan 2024 12:48:27 +0100 In-Reply-To: <87v88aa04w.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 03 Jan 2024 15:48:31 +0000") X-Provags-ID: V03:K1:ArKhxMDVaKt3IywgVXKlhV6EVjuOjiTRU80ytWLF2C1bJO5mE+g rIr0E8smuy+O1YjVPeg3uzC1S5Q3oJXzPOYLi+kq/4fL74VxESVD5kyG2Z3kqvm/1FDDu2F ZEU63/JtHtz9Kcbk4llfYiy9JVBxgvyduenhY7bMBZTe7uoI1stxtdi/5tV4MpSpmKdoctM yJCb1f4Xil2aYV3o1e4QA== UI-OutboundReport: notjunk:1;M01:P0:TVdPo0QaNUE=;hjrpXZCpi7MIdzXgCazdO4rqjEq b5d/e4Q8p2K2oSG61Vx58Bd6QMbNOsCw9YBovDZsmRyA/sC0JgSrLsxtyScOrY/lbnqgsG+JB 9Eaj/wqoKjSA9x25riLMgWCm5+ywiY5C2pgDq0MfTWsYgkBhv0nYU8UVLPBeN/1qgtVbg4d+k 7es1IGm5T97kdj4icPfHC90So+1+/9UqkBPrqp4ygBolNmrBuCswv/xFBHeyvhxKtLZCrVuEW cb6ySkLJdaayeni2++Lg2Qn4bIM+YfowCzTZIqpmO7WFvHsFIbREe6uH1kYxypf6RR+0Uj6Cu 7YdI2IkhIijYEpL0MaWf6Ak21xCKPLWHqfSeiqfpIXux5G5qd5QAHYMvA1U9zckQgh57ip22N UgMASsPkumY6Z5DJIGDzRw3m3xBag1C6SZ34WpN/dCurQkCGjxm6PSOFHJQk7T19zJLD8/q5R bi5/IrwymCUaUhp8MZvff0Qh47VHydggb0Pst5faF37yIijcL2YStJycLtVi4XY9FLHLwtAOb OXvs21cAt9DzLuFAfRrvU1+vKGpJ5kKEutRSkdwehCgi8cZFlZQ4kCQZVkP+2w4x99kFWcHpX qE9D8WuBXki4/OmfBwMoUaaUx48kGKCkO23ZNLyVxwmib1aKq02k6ewhn7BqRG8xY6rDoB+76 fUoxP1Qauh7jONJumH0LMX2yF3h8aY10aC7cmVVjrTBeHuIoB2Pc8x5m54BRNxbzDzkJw2CPm ZJjkCXeaBby0VOtdOCumF9ItaKfBaawDxl8M+ypcaahbRBz6PUThDMbvUqRhEz1SADOkTs2Z Received-SPF: pass client-ip=212.227.15.15; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314680 Archived-At: Philip Kaludercic writes: Hi, >>>> 1. emacs -Q >>>> 2. M-: (require 'tramp-adb) RET >>>> 3. M-x man RET ls RET >> >> Could it be that this is the issue: >> >> diff --git a/lisp/files-x.el b/lisp/files-x.el >> index 41d9cd3bab8..1911afe43e0 100644 >> --- a/lisp/files-x.el >> +++ b/lisp/files-x.el >> @@ -1,6 +1,6 @@ >> ;;; files-x.el --- extended file handling commands -*- lexical-bindin= g: t; -*- >> >> -;; Copyright (C) 2009-2023 Free Software Foundation, Inc. >> +;; Copyright (C) 2009-2024 Free Software Foundation, Inc. >> >> ;; Author: Juri Linkov >> ;; Maintainer: emacs-devel@gnu.org >> @@ -704,7 +704,7 @@ connection-local-get-profiles >> profiles) >> (dolist (crit-alist connection-local-criteria-alist) >> (let ((crit criteria) >> - (match t)) >> + (match nil)) >> (while (and crit match) >> (when (plist-member (car crit-alist) (car crit)) >> (setq match (equal (plist-get (car crit-alist) (car crit)) >> >> >> I am not quite sure what is going on in the function, but the invariant >> is that match is always non-nil after the loop is done, which seems >> suspicious to me. > > Never mind the last sentence, match can be nil if `equal' returns nil at > some point, but that doesn't happen locally since `criteria' is nil. Finally, I found the culprit. connection-local-value didn't handle a local default directory properly. Fix pushed to master. Again, since this is a macro, you need to recompile at least files-x.el and man.el (in this order). Or you run 'make bootstrap'. Best regrds, Michael.