From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Herman=2C_G=C3=A9za?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Implement fast verisons of json-parse functions Date: Tue, 19 Mar 2024 20:50:48 +0100 Message-ID: <874jd2rnwj.fsf@gmail.com> References: <87h6h2rsgn.fsf@gmail.com> <867chy3vpm.fsf@gnu.org> <87cyrqrqnb.fsf@gmail.com> <865xxi3tsu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22804"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?utf-8?Q?G=C3=A9za?= Herman , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 19 21:03:10 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rmffx-0005e2-QI for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Mar 2024 21:03:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmff3-0002sS-Dg; Tue, 19 Mar 2024 16:02:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmff1-0002rv-Qr for emacs-devel@gnu.org; Tue, 19 Mar 2024 16:02:11 -0400 Original-Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rmfez-0004PI-N0; Tue, 19 Mar 2024 16:02:11 -0400 Original-Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-563bb51c36eso7006290a12.2; Tue, 19 Mar 2024 13:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710878527; x=1711483327; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:references:from:to:cc:subject:date:message-id :reply-to; bh=+z+RGSsRRcb4aBdUucOSPJ9AMNGFEd4BsoHPY7t7mk0=; b=j77cX0kM5AR7zQKyjhJthpJH53F1b22Ezd6cNSuN8Zmi3gcJ2Gj27fp8LcpaEXoaj8 DeJOQLpS7G1vUz8DOuiTP90WX11n05DAFEPip973ITsL0YZRP6FMagvgf9O+VTDwxDCT FUez7ob2+GSbMz00E2z226PAtgaMKDtkjdkO98ZLtbK60Nw0VruDxLcD+/SlNNXeBN4g EJk+6i3IzVJ9KzvlwS7vlavRHCWcZeibe/XGhpdJ6fFNEX9F90Ee8H+obp/knS8OAOIj B3wNob8yz0+1utSfGCz8ZH4xJ4qB8WIWagiSU+9DNymxKKJ6TSP4VQc+ICXTeSfEF8GB Csrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710878527; x=1711483327; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:references:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=+z+RGSsRRcb4aBdUucOSPJ9AMNGFEd4BsoHPY7t7mk0=; b=bVS2Cslb82pTdThfFxw/k7qTvAgpJA/FXCZsPScgrzgf+RncPECby46gdw6PTO60la 2kb0R2WRWxkEU9ek1rSZ6OmbquUeYlk3gsVmhF6Bdox6S+kM2BEEePOxgun/pBuLBTXE 5+eAHo63eCfWuf+cdhT0oYhZpqnVmtdQRdL/ne9ihZIh7MlKJHTOhonaUP1RqI03WFI0 dAMQ1FyCIX6PVBr/IlSRfUxrCq638X5LizFEhY2xwIhWZHNx98SQTizpfQ2yZbgByrsr KKOrhlCKB3/vBtjcpbP0SA+K2hcKh5SyDHI79/HRQ/+imhwcihTDJ/bwPfs3bhMEOewi ky1A== X-Forwarded-Encrypted: i=1; AJvYcCUNkcLSHlfhbYG391LYSzkABYZ5iFJQVN9kppJH4C4Fbwz/X8bEqWbj7WkYyK7wFBikMjgImSM/CS0CpZCzjaY96ScR X-Gm-Message-State: AOJu0YwkDACMZUgQ+xDi2Frl/fdpbmGRQ+oTmkdpVaFtzvC7jQ+HS0KG BwjkyS/HUp2P9E+3oVXtePIMJEFBszbDXTs128bH5gAZsoINhXA71BPNFkxa X-Google-Smtp-Source: AGHT+IEJxgeUTb4q835Dui0ihhX7VEiqXGZlyvXzPI4kf4yCNmkaya7bBI2mrzKqzLpGO5ebai1OMg== X-Received: by 2002:a05:6402:1956:b0:56b:9f3d:8f34 with SMTP id f22-20020a056402195600b0056b9f3d8f34mr1612329edz.0.1710878526818; Tue, 19 Mar 2024 13:02:06 -0700 (PDT) Original-Received: from localhost (netacc-gpn-34-237-162.pool.yettel.hu. [37.234.237.162]) by smtp.gmail.com with ESMTPSA id et5-20020a056402378500b0056ba8b68505sm180635edb.92.2024.03.19.13.02.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 13:02:06 -0700 (PDT) In-reply-to: <865xxi3tsu.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=geza.herman@gmail.com; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317199 Archived-At: Eli Zaretskii writes: >> From: Herman, G=C3=A9za >> Cc: G=C3=A9za Herman , >> emacs-devel@gnu.org >> Date: Tue, 19 Mar 2024 19:50:26 +0100 >> >> I created this, because you previously said: " >> That's okay, we can start by making this an optional feature,=20 >> and >> consider making it the default after a couple of major=20 >> releases; >> meanwhile, any problems will be detected and reported." > > An optional feature I had in mind was conditional compilation,=20 > so that > users should decide at build time which version they want. But=20 > the > names and signatures of the functions exposed to Lisp should be=20 > the > same in both cases, so that Lisp programmers don't need to=20 > change > their programs to cater to both alternatives. > > Apologies if what I wrote was not clear enough about that. For=20 > the > future, I suggest that we discuss the practical implication of > significant changes before you go ahead and invest many hours in > implementing and testing them. I would like to avoid situations=20 > where > you invest significant efforts based on misunderstandings. Thank you for the great attitude! No worries, it only took ~10=20 minutes to create that version. And even if we don't want to have=20 that approach, it can still be useful for validation (comparing=20 the parsing results of the original and new parser) and=20 benchmarking purposes. If we want to have conditional compilation, is there a simple=20 similar conditional compilation case already in Emacs? So I can=20 copy the approach easily (supposedly I need to add a flag to=20 configure, it needs to add a -DUSE_OWN_JSON_PARSER switch to the=20 compiller, etc.)