From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] User-defined fringe tooltips (a request for review) Date: Wed, 27 Mar 2024 19:25:57 +0800 Message-ID: <874jcr6hmi.fsf@yahoo.com> References: <83sf3xgimq.fsf@gnu.org> <83plyzfoe4.fsf@gnu.org> <83plyxca0t.fsf@gnu.org> <8334vrczig.fsf@gnu.org> <86frwejkxe.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8200"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Vladimir Kazanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 27 12:27:00 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rpRQp-0001uY-Ok for ged-emacs-devel@m.gmane-mx.org; Wed, 27 Mar 2024 12:26:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rpRQT-0002Ke-Dl; Wed, 27 Mar 2024 07:26:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpRQP-0002K1-5W for emacs-devel@gnu.org; Wed, 27 Mar 2024 07:26:33 -0400 Original-Received: from sonic303-21.consmr.mail.ne1.yahoo.com ([66.163.188.147]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rpRQN-0007eP-IV for emacs-devel@gnu.org; Wed, 27 Mar 2024 07:26:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1711538789; bh=2pcrLNcG6vWHT0nfLtvzhspCM9+GDFDBldSEb3/26JY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=FNIaEE80lI+vEIGoUx50u4YxtY6uxIcShuhxba+yXhucz3DcnX1wVc4Jv1h6pn17gyzawH6h3R17rcYu0jXg87e89g6upVj6RBsbXrpMWt32eyIJp7rgFJyl85a6dbmW7z/393YNRRvUTWcSbSfcvbo8S761x3mqmQ6QARYWm2drxjOz0VlI8Es6sXdT3Q5ko6XPV4uVmZxLUhTO4beOVMgLHA/Rni/3Vy8bSc+YkFeZJ0zDeMBIs8Jmr/AABVH7sICOmbOY52qXlJCp3dKRDTXlr68bprqmFmc+xpjksvPqp/APV0Qe2ZG0IiE7N49J87bN638G0IQ3T8UzIps9pA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1711538790; bh=jhialtCGQFVcQtzib+bH12cletFrbfNvRxMMY8XhmKx=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=QfWJtZu8LjgkexNNTThirV2CVoHvu16mjc9iztK1yxKmE1VTKV/pJ5fjNjKSVHz7UaRkZ7DcXrBwZuITbV+w4a0DE+QdOnSRGEFUKAK01VEIYYKnA0PJZZTiXR9WqHOPz359nVYDJG12Taqy6WrtqsVJLsR3t0JxviaMURBN+vsyRNCfJyo87iD/xv21tpr7o6p+QXQsleXegPm0KOLsnExQ1clytJg8OPa33exN/cSEAwHf588DHr4q2n4zv0EBs71RiCWFTwSYP6a2lOvBQahw17VdwZJBNKoJXmdthL3ppu/2Cv3BC7RtxzLpPf5XbqAIEKtssgZi+CgW7T1iDA== X-YMail-OSG: u_ZxjfAVM1nwehVDTQCiwaHy_Hz5B2OUV5sghjiomTbSR2.DJXOXFCtfw5BvHJc vZLehmq6aqlap9ocSj2Cp6E2qVXHFasZAw6kSRwCdOjk9b8wRkQ0imsTOJi6daBC.YeosxeJujhi YraYb5731eTZPK.XvDmw.MI1ACoOOskAraIMPvKTlVw217KG0H8itzqvxJ3qHgpjatj6p7SeWKZm glqSe3sClBowG5uoogUKtnRVNtLc_jlqiE1CE_ZWTNey9Ryej_T_1T23bW5UbPUtkAQjFCfVRLHV WrrvVk91t2b3o_Q8XyQymNmqr65VfAYyPUPciwRhAzTi3KCvataiALlgWZW1rIL4opRQTXMihycB RISpEkW7G2CnMzCCScSTLBLkRwILgUjF3Md86cwyeyuubaIT11tWOu2LOwaK78uwaGK_DslscZW_ HozaDg5m9KTpCeJOysEGgf7UXaZhaQCIbQ8UhkjcV40XLMyXuyqgOBy5nTaYkJg836CC2VSWZ15S tzK1J4eHnwFux5U.NVLSTu.SGeP9J_zSKbzKKVgH9aNNePHg4.pXUvOuHxfNZRJYF_PgN4h0SQsz QNhBdcJgFKWG6KVlzte98jOZ_tDJoM2Ju9PDw3EYE30IOhDE6y7fhuUh6Ac8a4cQjRnqKZUV.8oR L0swn8NocPd4eS5qWf5Fm0GVN0ktHT_sCL6VoVqW1bdRvnwj5HnprpGCFHFxK9MoHxb9stEtPH19 6kanLGQxeZYHCG67DDuZyN5B46p.8A9WQQjPakqo4eO2JjcfyTkJ74TPZFP3Y7E7Xw9raGhGlDZb XmxdONClUpesHFKTIzRL1YZcnskOEsgkgiYy7Dqiiy X-Sonic-MF: X-Sonic-ID: 3dd5f4b3-c316-4d5a-9ad3-d46532fec439 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ne1.yahoo.com with HTTP; Wed, 27 Mar 2024 11:26:29 +0000 Original-Received: by hermes--production-sg3-6dc75bc8fb-7f5mm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 08e917a3c384f645429724cc6e3a0872; Wed, 27 Mar 2024 11:26:23 +0000 (UTC) In-Reply-To: (Vladimir Kazanov's message of "Wed, 27 Mar 2024 10:59:50 +0000") X-Mailer: WebService/1.1.22205 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.188.147; envelope-from=luangruo@yahoo.com; helo=sonic303-21.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317331 Archived-At: There are a number of general stylistic issues with this code, viz. the use of spaces for indentation, to columns beyond the tab width, the presence of redundant braces in if/else statements, and that of lines exceeding 80 columns. Please see that they are addressed before it is installed in Emacs, and thanks in advance.