From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Interest in temporary with-advice functionality? Date: Fri, 21 Jun 2024 20:51:34 +0200 Message-ID: <874j9mnn7t.fsf@web.de> References: <18b80475-e3b4-2a88-1ee4-26a88fc56143@gmail.com> Reply-To: Michael Heerdegen Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13189"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:Vh41mocQCCIlAZvqMJ0A7jqXtWc= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 21 20:51:27 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKjM6-0003J2-7s for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Jun 2024 20:51:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKjLc-0006Ne-GW; Fri, 21 Jun 2024 14:50:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKjLZ-0006NG-L4 for emacs-devel@gnu.org; Fri, 21 Jun 2024 14:50:54 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKjLY-0005R8-6I for emacs-devel@gnu.org; Fri, 21 Jun 2024 14:50:53 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1sKjLS-0002SP-OC for emacs-devel@gnu.org; Fri, 21 Jun 2024 20:50:46 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320433 Archived-At: Jim Porter writes: > On 6/17/2024 9:12 PM, Campbell Barton wrote: > > While `cl-letf` can be used, advice is especially useful for it's > > :around functionality, while possible, it gets fairly verbose to use > > cl-letf to override the function in a way that supports calling the > > original. > > I've been using a "with-advice" macro (see [0]). > > The macros temporarily adds, then removed the advice > [snip] > > I was wondering if there is any interest to have this added to emacs. > > I've done this sort of temporary-advising more than a handful of times > (mostly in my init.el to work around various bugs on older Emacs > versions), and would find it useful. Me too. But OTOH it's only a tool to write down _hacks_ more conveniently. We don't want this in Emacs IMO. OTOH, such a functionality can definitely be useful for advanced users. On the third hand, my concern is that having this easily available might drive unexperienced users into a wrong direction. So the current state ("people who know what they are doing implement this feature by and for themselves and will understand the downsides by themselves) maybe is an optimum. Michael.