* Recent isearch changes in eshell
@ 2024-12-16 14:01 Colin Baxter
2024-12-16 14:25 ` Andreas Schwab
0 siblings, 1 reply; 5+ messages in thread
From: Colin Baxter @ 2024-12-16 14:01 UTC (permalink / raw)
To: emacs-devel
Recently, isearch in eshell was changed. According to NEWS, the
following will revert the changes:
--8<---------------cut here---------------start------------->8---
(keymap-set eshell-hist-mode-map "M-r"
#'eshell-previous-matching-input)
(keymap-set eshell-hist-mode-map "M-s"
#'eshell-next-matching-input)
--8<---------------cut here---------------end--------------->8---
It seems that the above will only work if they are evaluated after
calling eshell, otherwise they give "void variable eshell-hist-mode-map"
error.
Can anyone suggest how I might revert the changes without having to eval
the above keymap-set in a scratch buffer after "M-x eshell <RET>"? I have
tried eval after load in my ~/.emacs but that appears to have no effect.
Thank you.
Colin Baxter.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Recent isearch changes in eshell
2024-12-16 14:01 Recent isearch changes in eshell Colin Baxter
@ 2024-12-16 14:25 ` Andreas Schwab
2024-12-16 14:40 ` Colin Baxter
2024-12-18 5:25 ` Jim Porter
0 siblings, 2 replies; 5+ messages in thread
From: Andreas Schwab @ 2024-12-16 14:25 UTC (permalink / raw)
To: Colin Baxter; +Cc: emacs-devel
On Dez 16 2024, Colin Baxter wrote:
> Recently, isearch in eshell was changed. According to NEWS, the
> following will revert the changes:
>
> (keymap-set eshell-hist-mode-map "M-r"
> #'eshell-previous-matching-input)
> (keymap-set eshell-hist-mode-map "M-s"
> #'eshell-next-matching-input)
>
> It seems that the above will only work if they are evaluated after
> calling eshell, otherwise they give "void variable eshell-hist-mode-map"
> error.
(with-eval-after-load 'em-hist ...)
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Recent isearch changes in eshell
2024-12-16 14:25 ` Andreas Schwab
@ 2024-12-16 14:40 ` Colin Baxter
2024-12-18 5:25 ` Jim Porter
1 sibling, 0 replies; 5+ messages in thread
From: Colin Baxter @ 2024-12-16 14:40 UTC (permalink / raw)
To: Andreas Schwab; +Cc: emacs-devel
>>>>> Andreas Schwab <schwab@suse.de> writes:
> On Dez 16 2024, Colin Baxter wrote:
>> Recently, isearch in eshell was changed. According to NEWS, the
>> following will revert the changes:
>>
>> (keymap-set eshell-hist-mode-map "M-r"
>> #'eshell-previous-matching-input) (keymap-set
>> eshell-hist-mode-map "M-s" #'eshell-next-matching-input)
>>
>> It seems that the above will only work if they are evaluated
>> after calling eshell, otherwise they give "void variable
>> eshell-hist-mode-map" error.
> (with-eval-after-load 'em-hist ...)
Thank you! That worked.
I wonder if perhaps NEWS could be amended to include this?
Colin Baxter.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Recent isearch changes in eshell
2024-12-16 14:25 ` Andreas Schwab
2024-12-16 14:40 ` Colin Baxter
@ 2024-12-18 5:25 ` Jim Porter
2024-12-18 18:02 ` Colin Baxter
1 sibling, 1 reply; 5+ messages in thread
From: Jim Porter @ 2024-12-18 5:25 UTC (permalink / raw)
To: Andreas Schwab, Colin Baxter; +Cc: emacs-devel
On 12/16/2024 6:25 AM, Andreas Schwab wrote:
> On Dez 16 2024, Colin Baxter wrote:
>
>> Recently, isearch in eshell was changed. According to NEWS, the
>> following will revert the changes:
>>
>> (keymap-set eshell-hist-mode-map "M-r"
>> #'eshell-previous-matching-input)
>> (keymap-set eshell-hist-mode-map "M-s"
>> #'eshell-next-matching-input)
>>
>> It seems that the above will only work if they are evaluated after
>> calling eshell, otherwise they give "void variable eshell-hist-mode-map"
>> error.
>
> (with-eval-after-load 'em-hist ...)
Thanks (and thanks for Colin for reporting this). Now fixed in 43fcda0c8ea.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Recent isearch changes in eshell
2024-12-18 5:25 ` Jim Porter
@ 2024-12-18 18:02 ` Colin Baxter
0 siblings, 0 replies; 5+ messages in thread
From: Colin Baxter @ 2024-12-18 18:02 UTC (permalink / raw)
To: Jim Porter; +Cc: Andreas Schwab, emacs-devel
>>>>> Jim Porter <jporterbugs@gmail.com> writes:
> On 12/16/2024 6:25 AM, Andreas Schwab wrote:
>> On Dez 16 2024, Colin Baxter wrote:
>>
>>> Recently, isearch in eshell was changed. According to NEWS, the
>>> following will revert the changes:
>>>
>>> (keymap-set eshell-hist-mode-map "M-r"
>>> #'eshell-previous-matching-input) (keymap-set
>>> eshell-hist-mode-map "M-s" #'eshell-next-matching-input)
>>>
>>> It seems that the above will only work if they are evaluated
>>> after calling eshell, otherwise they give "void variable
>>> eshell-hist-mode-map" error.
>> (with-eval-after-load 'em-hist ...)
> Thanks (and thanks for Colin for reporting this). Now fixed in
> 43fcda0c8ea.
Thank you. I very much appreciate your addition to the NEWS item.
Best wishes,
Colin Baxter.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-12-18 18:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-16 14:01 Recent isearch changes in eshell Colin Baxter
2024-12-16 14:25 ` Andreas Schwab
2024-12-16 14:40 ` Colin Baxter
2024-12-18 5:25 ` Jim Porter
2024-12-18 18:02 ` Colin Baxter
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).