From: Colin Baxter <m43cap@yandex.com>
To: Jim Porter <jporterbugs@gmail.com>
Cc: Andreas Schwab <schwab@suse.de>, emacs-devel@gnu.org
Subject: Re: Recent isearch changes in eshell
Date: Wed, 18 Dec 2024 18:02:22 +0000 [thread overview]
Message-ID: <874j30lvip.fsf@yandex.com> (raw)
In-Reply-To: <87cfd588-a2e0-dd39-9fde-3c9350260e56@gmail.com> (Jim Porter's message of "Tue, 17 Dec 2024 21:25:18 -0800")
>>>>> Jim Porter <jporterbugs@gmail.com> writes:
> On 12/16/2024 6:25 AM, Andreas Schwab wrote:
>> On Dez 16 2024, Colin Baxter wrote:
>>
>>> Recently, isearch in eshell was changed. According to NEWS, the
>>> following will revert the changes:
>>>
>>> (keymap-set eshell-hist-mode-map "M-r"
>>> #'eshell-previous-matching-input) (keymap-set
>>> eshell-hist-mode-map "M-s" #'eshell-next-matching-input)
>>>
>>> It seems that the above will only work if they are evaluated
>>> after calling eshell, otherwise they give "void variable
>>> eshell-hist-mode-map" error.
>> (with-eval-after-load 'em-hist ...)
> Thanks (and thanks for Colin for reporting this). Now fixed in
> 43fcda0c8ea.
Thank you. I very much appreciate your addition to the NEWS item.
Best wishes,
Colin Baxter.
prev parent reply other threads:[~2024-12-18 18:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 14:01 Recent isearch changes in eshell Colin Baxter
2024-12-16 14:25 ` Andreas Schwab
2024-12-16 14:40 ` Colin Baxter
2024-12-18 5:25 ` Jim Porter
2024-12-18 18:02 ` Colin Baxter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j30lvip.fsf@yandex.com \
--to=m43cap@yandex.com \
--cc=emacs-devel@gnu.org \
--cc=jporterbugs@gmail.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).