From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Rob Browning Newsgroups: gmane.emacs.devel Subject: Re: Building emacs with and without X -- packaging question. Date: Sat, 14 Sep 2002 16:16:13 -0500 Sender: emacs-devel-admin@gnu.org Message-ID: <873cscw9uq.fsf@raven.i.defaultvalue.org> References: <87adppy67u.fsf@raven.i.defaultvalue.org> <3405-Fri21Jun2002183331+0300-eliz@is.elta.co.il> <871yaz2tf8.fsf@raven.i.defaultvalue.org> <87k7nbacm7.fsf@raven.i.defaultvalue.org> <200208020611.g726BkU01069@aztec.santafe.edu> <877kj96z74.fsf@raven.i.defaultvalue.org> <200208040252.g742qam02724@aztec.santafe.edu> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1032038276 11845 127.0.0.1 (14 Sep 2002 21:17:56 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sat, 14 Sep 2002 21:17:56 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 17qKId-00034v-00 for ; Sat, 14 Sep 2002 23:17:55 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17qKvA-0000qd-00 for ; Sat, 14 Sep 2002 23:57:44 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 17qKIp-0004CT-00; Sat, 14 Sep 2002 17:18:07 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 17qKH3-00046V-00 for emacs-devel@gnu.org; Sat, 14 Sep 2002 17:16:17 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 17qKH1-00046G-00 for emacs-devel@gnu.org; Sat, 14 Sep 2002 17:16:16 -0400 Original-Received: from [66.64.4.228] (helo=defaultvalue.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 17qKH0-00046A-00; Sat, 14 Sep 2002 17:16:14 -0400 Original-Received: from raven.i.defaultvalue.org (raven.i.defaultvalue.org [192.168.1.7]) by defaultvalue.org (Postfix) with ESMTP id 09827920; Sat, 14 Sep 2002 16:16:14 -0500 (CDT) Original-Received: by raven.i.defaultvalue.org (Postfix, from userid 1000) id C533A72C; Sat, 14 Sep 2002 16:16:13 -0500 (CDT) Original-To: rms@gnu.org In-Reply-To: <200208040252.g742qam02724@aztec.santafe.edu> (Richard Stallman's message of "Sat, 3 Aug 2002 20:52:36 -0600 (MDT)") Original-Lines: 66 User-Agent: Gnus/5.090006 (Oort Gnus v0.06) Emacs/21.2 (i386-pc-linux-gnu) Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:7907 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:7907 Richard Stallman writes: > Sure I can try. I presume you're talking about this diff: > > -(put 'frames 'custom-loads '( "desktop" "ediff-wind" "faces" "frame" "imenu" "menu-bar" "rsz-mini" "scroll-bar" "two-column")) > +(put 'frames 'custom-loads '( "desktop" "ediff-wind" "faces" "frame" "imenu" "menu-bar" "rsz-mini" "two-column")) > > That one and the other one, both. > > Is this one related, or likely something else? > > -(custom-put-if-not 'gnus-article-x-face-command 'custom-version "21.1") > -(custom-put-if-not 'gnus-article-x-face-command 'standard-value t) > > There is no way of knowing a priori whether they are related. I finally had time to work on this, and I think I've tracked it down. In cus-dep.el we have: (let ((expr (read (current-buffer)))) (condition-case nil (progn (eval expr) (put (nth 1 expr) 'custom-autoloaded is-autoloaded) (put (nth 1 expr) 'custom-where name)) (error nil)))) Note that the condition-case ignores errors. However, if you rewrite the above to actually catch the signalled-condition data and print it via message, you will find that when compiling --with-x=no, there's an error while handling both the scroll-bar-mode and gnus-article-x-face-command defcustoms. In the scroll-bar-mode case this appears to be because set-scroll-bar-mode-1 is undefined, even though it's used as the :set value in the relevant defcustom: (defcustom scroll-bar-mode (if (eq system-type 'windows-nt) 'right 'left) "*Specify whether to have vertical scroll bars, and on which side. Possible values are nil (no scroll bars), `left' (scroll bars on left) and `right' (scroll bars on right). To set this variable in a Lisp program, use `set-scroll-bar-mode' to make it take real effect. Setting the variable with a customization buffer also takes effect." :type '(choice (const :tag "none (nil)") (const left) (const right)) :group 'frames :set 'set-scroll-bar-mode-1) The actual condition-case signalled-condition data for this error is (void-function set-scroll-bar-mode-1), and removing the :set line from the defcustom fixes the problem, at least to the extent that the scroll-bar related diff in cus-dep.el goes away. For gnus-article-x-face-command, the condition-case signalled-condition data is (void-variable gnus-article-compface-xbm). If my analysis is right, is this something that should be fixed, and if so, what would be the right way to fix it? Thanks -- Rob Browning rlb @defaultvalue.org, @linuxdevel.com, and @debian.org Previously @cs.utexas.edu GPG=1C58 8B2C FB5E 3F64 EA5C 64AE 78FE E5FE F0CB A0AD