From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: next-error-last-buffer Date: Mon, 10 May 2004 02:32:34 +0300 Organization: JURTA Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <873c6983t9.fsf@mail.jurta.org> References: <871xluig40.fsf@mail.jurta.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1084154221 12348 80.91.224.253 (10 May 2004 01:57:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 10 May 2004 01:57:01 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon May 10 03:56:52 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BN02G-0004nz-00 for ; Mon, 10 May 2004 03:56:52 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BN02G-0002KH-00 for ; Mon, 10 May 2004 03:56:52 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.33) id 1BMzye-0000wr-5I for emacs-devel@quimby.gnus.org; Sun, 09 May 2004 21:53:08 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.33) id 1BMzy5-0000wc-V7 for emacs-devel@gnu.org; Sun, 09 May 2004 21:52:34 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.33) id 1BMzxY-0000pm-No for emacs-devel@gnu.org; Sun, 09 May 2004 21:52:32 -0400 Original-Received: from [66.33.219.19] (helo=spoon.dreamhost.com) by monty-python.gnu.org with esmtp (Exim 4.33) id 1BMzxY-0000pg-G2; Sun, 09 May 2004 21:52:00 -0400 Original-Received: from mail.jurta.org (80-235-33-105-dsl.mus.estpak.ee [80.235.33.105]) by spoon.dreamhost.com (Postfix) with ESMTP id E66FD13D8CE; Sun, 9 May 2004 18:51:57 -0700 (PDT) Original-To: rms@gnu.org In-Reply-To: (Richard Stallman's message of "Sun, 09 May 2004 14:47:36 -0400") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:23014 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:23014 Richard Stallman writes: > I think that `next-error-last-buffer' should be set buffer-locally > in the compilation buffer > > Isn't next-error in a compilation buffer already supposed to operate > on the current buffer? If so, this change would be a no-op. > It might be that this is a cleaner way to implement that feature > than the code that currently implements it. Yes, setting `next-error-last-buffer' locally in the compilation buffer is not necessary with the current logic in `next-error-find-buffer', but it could be set only for consistency. > as well as in every source file visited > from that compilation buffer. > > That is an interesting idea, but I think it will screw up the > interaction between compilation and occur, which was the whole point > of the recent changes. I tested this change, and it seems to work correctly with occur, i.e. it allows to continue visiting next occurrences from the same occur buffer where the current source buffer was visited from, even if it is not from the last occur/compile/grep. However, `occur-next-error' has its own problems that should be fixed (it can't jump to multiple occurrences on the same line, it don't move the point in the occur buffer like `compilation-goto-locus' does). -- Juri Linkov http://www.jurta.org/emacs/