From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Matt Hodges Newsgroups: gmane.emacs.devel Subject: Re: New faces in iswitchb Date: Mon, 06 Jun 2005 14:23:48 +0100 Message-ID: <873brvy5y3.fsf@warwick.ac.uk> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: sea.gmane.org 1118064451 17121 80.91.229.2 (6 Jun 2005 13:27:31 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 6 Jun 2005 13:27:31 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 06 15:27:23 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DfHcW-00032h-13 for ged-emacs-devel@m.gmane.org; Mon, 06 Jun 2005 15:26:24 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DfHip-0002NJ-BT for ged-emacs-devel@m.gmane.org; Mon, 06 Jun 2005 09:32:55 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DfHiU-0002LN-LH for emacs-devel@gnu.org; Mon, 06 Jun 2005 09:32:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DfHiR-0002Hq-0T for emacs-devel@gnu.org; Mon, 06 Jun 2005 09:32:31 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DfHiQ-0002HY-R3 for emacs-devel@gnu.org; Mon, 06 Jun 2005 09:32:30 -0400 Original-Received: from [137.205.128.8] (helo=mail-relay-2.warwick.ac.uk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DfHdl-0006PR-2t; Mon, 06 Jun 2005 09:27:41 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail-relay-2.csv.warwick.ac.uk (8.12.11/8.12.9) with ESMTP id j56DOKMA025488; Mon, 6 Jun 2005 14:24:20 +0100 (BST) Original-Received: from mail-relay-2.csv.warwick.ac.uk ([127.0.0.1]) by localhost (campion [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 13745-32-4; Mon, 6 Jun 2005 14:24:17 +0100 (BST) Original-Received: from dugong ([137.205.109.40]) by mail-relay-2.csv.warwick.ac.uk (8.12.11/8.12.9) with ESMTP id j56DNtdN025146; Mon, 6 Jun 2005 14:23:56 +0100 (BST) X-Envelope-From: MPHodges@member.fsf.org Original-Received: from matt by dugong with local (Exim 4.50) id 1DfHa1-0003Yw-Nc; Mon, 06 Jun 2005 14:23:49 +0100 Original-To: storm@cua.dk (Kim F. Storm) In-Reply-To: (Kim F. Storm's message of "Mon, 06 Jun 2005 14:44:47 +0200") User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/22.0.50 (gnu/linux) X-Virus-Scanned: amavisd-new at warwick.ac.uk X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:38173 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:38173 --=-=-= >>>>> Kim Storm writes: > we generally try to avoid naming faces with -face suffix, as they > have their own namespace. Pls. change the new face names > accordingly. Sorry, I should have been aware of this. Is it mentioned somewhere? I couldn't find it in (info "(elisp)Coding Conventions."), for example. Can someone install the attached? Thanks, Matt --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Description: iswitchb.el patch. Index: lisp/iswitchb.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/iswitchb.el,v retrieving revision 1.57 diff -u -r1.57 iswitchb.el --- lisp/iswitchb.el 4 Jun 2005 19:10:07 -0000 1.57 +++ lisp/iswitchb.el 6 Jun 2005 13:10:47 -0000 @@ -404,21 +404,21 @@ :type 'hook :group 'iswitchb) -(defface iswitchb-single-match-face +(defface iswitchb-single-match '((t (:inherit font-lock-comment-face))) "Iswitchb face for single matching buffer name." :version "22.1" :group 'iswitchb) -(defface iswitchb-current-match-face +(defface iswitchb-current-match '((t (:inherit font-lock-function-name-face))) "Iswitchb face for current matching buffer name." :version "22.1" :group 'iswitchb) -(defface iswitchb-virtual-matches-face +(defface iswitchb-virtual-matches '((t (:inherit font-lock-builtin-face))) "Iswitchb face for matching virtual buffer names. @@ -426,7 +426,7 @@ :version "22.1" :group 'iswitchb) -(defface iswitchb-invalid-regexp-face +(defface iswitchb-invalid-regexp '((t (:inherit font-lock-warning-face))) "Iswitchb face for indicating invalid regexp. " @@ -1299,9 +1299,9 @@ (put-text-property 0 (length first) 'face (if (= (length comps) 1) (if iswitchb-invalid-regexp - 'iswitchb-invalid-regexp-face - 'iswitchb-single-match-face) - 'iswitchb-current-match-face) + 'iswitchb-invalid-regexp + 'iswitchb-single-match) + 'iswitchb-current-match) first) (setq comps (cons first (cdr comps))))) @@ -1330,7 +1330,7 @@ (let ((comp comps)) (while comp (put-text-property 0 (length (car comp)) - 'face 'iswitchb-virtual-matches-face + 'face 'iswitchb-virtual-matches (car comp)) (setq comp (cdr comp)))))) --=-=-= Content-Disposition: attachment; filename=ChangeLog Content-Description: ChangeLog entry. 2005-06-06 Matt Hodges * iswitchb.el: Rename faces. --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --=-=-=--