From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: rcirc bug Date: Thu, 07 Sep 2006 16:59:29 -0400 Message-ID: <873bb3fl5a.fsf@stupidchicken.com> References: <20060904135111.7ADB544005@Psilocybe.Update.UU.SE> <87mz9eknqm.fsf@cut.bc.hsia.telus.net> <87u03mdm4g.fsf@freemail.hu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1157662690 26275 80.91.229.2 (7 Sep 2006 20:58:10 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 7 Sep 2006 20:58:10 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 07 22:58:09 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GLQwi-0001bT-EN for ged-emacs-devel@m.gmane.org; Thu, 07 Sep 2006 22:58:01 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GLQwi-00009K-15 for ged-emacs-devel@m.gmane.org; Thu, 07 Sep 2006 16:58:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GLQwT-0008Ui-MB for emacs-devel@gnu.org; Thu, 07 Sep 2006 16:57:45 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GLQwR-0008M2-R5 for emacs-devel@gnu.org; Thu, 07 Sep 2006 16:57:45 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GLQwR-0008L7-L1 for emacs-devel@gnu.org; Thu, 07 Sep 2006 16:57:43 -0400 Original-Received: from [18.19.1.138] (helo=cyd) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GLQwt-0004ZZ-C8 for emacs-devel@gnu.org; Thu, 07 Sep 2006 16:58:11 -0400 Original-Received: by cyd (Postfix, from userid 1000) id 945C74ECD0; Thu, 7 Sep 2006 16:59:29 -0400 (EDT) Original-To: emacs-devel@gnu.org In-Reply-To: <87u03mdm4g.fsf@freemail.hu> (Magnus Henoch's message of "Tue\, 05 Sep 2006 23\:44\:31 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:59519 Archived-At: Magnus Henoch writes: > Ryan Yeske writes: > >> The following patch fixes this: > > So does this patch, but it gets to keep the `case'. `case' uses > `member*' only when there is more than one alternative in a clause. > Using a quoted value in a case clause counts as more than one > alternative, as 'nick is equal to (quote nick), but values in case > clauses are not evaluated. I believe this is right. Since no one seems to have any objections, I've checked it into CVS. > *** orig/lisp/net/rcirc.el > --- mod/lisp/net/rcirc.el > *************** > *** 1545,1552 **** > (dolist (type rcirc-activity-types) > (rcirc-add-face 0 (length s) > (case type > ! ('nick 'rcirc-track-nick) > ! ('keyword 'rcirc-track-keyword)) > s))) > s)) > buffers ",")) > --- 1545,1552 ---- > (dolist (type rcirc-activity-types) > (rcirc-add-face 0 (length s) > (case type > ! (nick 'rcirc-track-nick) > ! (keyword 'rcirc-track-keyword)) > s))) > s)) > buffers ","))