unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
Subject: Re: rcirc bug
Date: Thu, 07 Sep 2006 16:59:29 -0400	[thread overview]
Message-ID: <873bb3fl5a.fsf@stupidchicken.com> (raw)
In-Reply-To: <87u03mdm4g.fsf@freemail.hu> (Magnus Henoch's message of "Tue\, 05 Sep 2006 23\:44\:31 +0200")

Magnus Henoch <mange@freemail.hu> writes:

> Ryan Yeske <rcyeske@gmail.com> writes:
>
>> The following patch fixes this:
>
> So does this patch, but it gets to keep the `case'.  `case' uses
> `member*' only when there is more than one alternative in a clause.
> Using a quoted value in a case clause counts as more than one
> alternative, as 'nick is equal to (quote nick), but values in case
> clauses are not evaluated.

I believe this is right.  Since no one seems to have any objections,
I've checked it into CVS.

> *** orig/lisp/net/rcirc.el
> --- mod/lisp/net/rcirc.el
> ***************
> *** 1545,1552 ****
>   		   (dolist (type rcirc-activity-types)
>   		     (rcirc-add-face 0 (length s)
>   				     (case type
> ! 				       ('nick 'rcirc-track-nick)
> ! 				       ('keyword 'rcirc-track-keyword))
>   				     s)))
>   		 s))
>   	     buffers ","))
> --- 1545,1552 ----
>   		   (dolist (type rcirc-activity-types)
>   		     (rcirc-add-face 0 (length s)
>   				     (case type
> ! 				       (nick 'rcirc-track-nick)
> ! 				       (keyword 'rcirc-track-keyword))
>   				     s)))
>   		 s))
>   	     buffers ","))

  reply	other threads:[~2006-09-07 20:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-04 13:51 rcirc bug Alfred M. Szmidt
2006-09-05  9:42 ` Richard Stallman
2006-09-05 21:27 ` Ryan Yeske
2006-09-05 21:37   ` Alfred M. Szmidt
2006-09-05 21:44     ` Ryan Yeske
2006-09-06 19:06     ` Richard Stallman
2006-09-06 19:13       ` Ryan Yeske
2006-09-07 23:19     ` Ryan Yeske
2006-09-08 15:11       ` Richard Stallman
2006-09-08 15:30         ` Drew Adams
2006-09-11  2:57         ` Chong Yidong
2006-09-11 15:17           ` Stuart D. Herring
2006-09-11 19:57           ` Richard Stallman
2006-09-05 21:44   ` Magnus Henoch
2006-09-07 20:59     ` Chong Yidong [this message]
2006-09-07 21:11     ` Stefan Monnier
2006-09-05 21:46   ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873bb3fl5a.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).