From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: Top posting related changes in the cvs Date: Tue, 03 Apr 2007 23:38:37 +0200 Message-ID: <873b3hm942.fsf@ambire.localdomain> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1175636374 15788 80.91.229.12 (3 Apr 2007 21:39:34 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 3 Apr 2007 21:39:34 +0000 (UTC) Cc: ding@gnus.org, emacs-devel@gnu.org To: "Gabor Z. Papp" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 03 23:39:33 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HYqix-0006I7-La for ged-emacs-devel@m.gmane.org; Tue, 03 Apr 2007 23:39:31 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HYqm8-0002f9-Uk for ged-emacs-devel@m.gmane.org; Tue, 03 Apr 2007 17:42:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HYqm4-0002aF-Sh for emacs-devel@gnu.org; Tue, 03 Apr 2007 17:42:44 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HYqm3-0002ZX-CI for emacs-devel@gnu.org; Tue, 03 Apr 2007 17:42:44 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HYqm3-0002ZU-8E for emacs-devel@gnu.org; Tue, 03 Apr 2007 17:42:43 -0400 Original-Received: from smtp-out3.libero.it ([212.52.84.43]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HYqiq-0002oE-VQ for emacs-devel@gnu.org; Tue, 03 Apr 2007 17:39:25 -0400 Original-Received: from localhost (172.31.0.41) by smtp-out3.libero.it (7.3.120) id 4611FE5E0011E8C5; Tue, 3 Apr 2007 23:38:46 +0200 X-Scanned: with antispam and antivirus automated system at libero.it Original-Received: from smtp-out1.libero.it ([172.31.0.37]) by localhost (asav-out1.libero.it [192.168.32.29]) (amavisd-new, port 10024) with ESMTP id wFh-EGibQvGf; Tue, 3 Apr 2007 23:38:46 +0200 (CEST) Original-Received: from ambire.localdomain (151.21.32.188) by smtp-out1.libero.it (7.3.120) id 4611FC9100143E56; Tue, 3 Apr 2007 23:38:46 +0200 Original-Received: from ttn by ambire.localdomain with local (Exim 4.50) id 1HYqiC-0001sm-DJ; Tue, 03 Apr 2007 23:38:44 +0200 In-Reply-To: (Reiner Steib's message of "Tue\, 03 Apr 2007 22\:45\:08 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.96 (gnu/linux) X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:69017 gmane.emacs.gnus.general:64492 Archived-At: () Reiner Steib () Tue, 03 Apr 2007 22:45:08 +0200 ,---- | 2007-03-27 Thien-Thi Nguyen | | * message.el (message-yank-original): Fix bug: | Don't switch point and mark unnecessarily. `---- Thien-Thi, could you please explain which bug you intended to fix? To put the cursor immediately after the citation line ("Whomever writes:" line). The user should start editing there, removing the cited portions the he won't reply to. before the fix, yanking would leave the cursor after the yanked messages, contrary to the docstring. the fix, to regain concordance w/ the docstring, involves conditionalizing a previously unconditional call to exchange-point-and-mark. i believe the original unconditional call was correct (necessary) prior to another change: 2005-08-01 Katsumi Yamaoka * gnus-uu.el (gnus-uu-save-article): Use insert-buffer-substring instead of insert-buffer. * message.el (message-yank-original): Ditto; set the mark at the end of the yanked message. insert-buffer-substring inserts before point, while insert-buffer inserts after point. my analysis is that the exchange-point-and-mark relied on insert-buffer's behavior, and thus became incorrect after the 2005-08-01 change, since point and mark were already in the correct order. my fix (to conditionalize the call) removes the direct dependency so that the desired ending position of point will be as documented for whatever function is used (now or in the future) to do the insert, as long as the inserted text is bracketed by point and mark. an alternative fix that is less robust against future changes is to rely on the behavior of insert-buffer-substring and simply remove the call to exchange-point-and-mark. then we can chase this bug again later for hours of fun... When doing changes in Gnus it would be nice to dicuss such changes on ding@gnus.org - especially WRT the upcoming Emacs release (in this case, I didn't even see any discussion on emacs-devel or on the pretest-list). Unless there is a very good reason for this change, I intend to revert it. I certainly don't want Gnus in Emacs 22 behave this way by default! i think the behavior, leaving point between the citation and the yanked text, is nice. i was happy to read about it in the docstring. it seems whoever wrote the original (concording) code+docstring was thoughtful. thi