From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Changes to hi-lock before release. Date: Sat, 21 Apr 2007 22:45:56 -0400 Message-ID: <873b2tjfdn.fsf@stupidchicken.com> References: <7wejmekgrd.fsf@ece.lsu.edu> <87zm51ab0b.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1177209979 23129 80.91.229.12 (22 Apr 2007 02:46:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 22 Apr 2007 02:46:19 +0000 (UTC) Cc: koppel@ece.lsu.edu, emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 22 04:46:13 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HfS5c-0004or-E5 for ged-emacs-devel@m.gmane.org; Sun, 22 Apr 2007 04:46:12 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HfSAr-0006eZ-0D for ged-emacs-devel@m.gmane.org; Sat, 21 Apr 2007 22:51:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HfSAn-0006eU-Ti for emacs-devel@gnu.org; Sat, 21 Apr 2007 22:51:33 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HfSAm-0006eM-JH for emacs-devel@gnu.org; Sat, 21 Apr 2007 22:51:32 -0400 Original-Received: from south-station-annex.mit.edu ([18.72.1.2]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HfS5X-0006nX-D1; Sat, 21 Apr 2007 22:46:07 -0400 Original-Received: from grand-central-station.mit.edu (GRAND-CENTRAL-STATION.MIT.EDU [18.7.21.82]) by south-station-annex.mit.edu (8.13.6/8.9.2) with ESMTP id l3M2k55f012283; Sat, 21 Apr 2007 22:46:05 -0400 (EDT) Original-Received: from outgoing-legacy.mit.edu (OUTGOING-LEGACY.MIT.EDU [18.7.22.104]) by grand-central-station.mit.edu (8.13.6/8.9.2) with ESMTP id l3M2jvLZ029041; Sat, 21 Apr 2007 22:45:58 -0400 (EDT) Original-Received: from localhost (SYDNEYPACIFIC-SIX-TWENTY.MIT.EDU [18.95.7.109]) ) by outgoing-legacy.mit.edu (8.13.6/8.12.4) with ESMTP id l3M2juYP017636; Sat, 21 Apr 2007 22:45:57 -0400 (EDT) Original-Received: from cyd by localhost with local (Exim 3.36 #1 (Debian)) id 1HfS5M-0007wW-00; Sat, 21 Apr 2007 22:45:56 -0400 In-Reply-To: (Richard Stallman's message of "Sat\, 21 Apr 2007 20\:46\:35 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.98 (gnu/linux) X-Scanned-By: MIMEDefang 2.42 X-Spam-Score: -2.599 X-detected-kernel: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:69768 Archived-At: Richard Stallman writes: > > Also, it seems absurd for an explicit call to hi-lock-find-patterns to > > check this variable. If the user explicitly gives the command, it > > should be obeyed. I think that hi-lock-file-patterns-policy should be > > tested only when hi-lock-find-patterns is called in other ways (such > > as by find-file). > > What you suggested is indeed the behavior of hi-lock-find-patterns. > > I don't see it. hi-lock-find-patterns takes no arguments > and it never bypasses checking hi-lock-file-patterns-policy. > How does it distinguish explicit M-x calls from calls that come from hooks? (when (and all-patterns hi-lock-mode (cond ((eq this-command 'hi-lock-find-patterns) t) ...