vc.el no longer recognizes files in an arch working directory

vc.el no longer recognizes files in an arch working directory

[Miles Bader]

Using current CVS (emacs -Q), if I visit a file in an arch working
directory, vc.el doesn't seem to recognize that:  no modeline indicator,
vc commands give an error "File ... is not under version control".

This used to work just fine of course.

It still works OK with files in a CVS working directory however.

-Miles
-- 
If you can't beat them, arrange to have them beaten.  [George Carlin]

Re: vc.el no longer recognizes files in an arch working directory

[Chong Yidong]

Miles Bader <miles.bader@necel.com> writes:

> Using current CVS (emacs -Q), if I visit a file in an arch working
> directory, vc.el doesn't seem to recognize that:  no modeline indicator,
> vc commands give an error "File ... is not under version control".
>
> This used to work just fine of course.
>
> It still works OK with files in a CVS working directory however.

Is this the branch or trunk?

Re: vc.el no longer recognizes files in an arch working directory

[Miles Bader]

Chong Yidong <cyd@stupidchicken.com> writes:
>> Using current CVS (emacs -Q), if I visit a file in an arch working
>> directory, vc.el doesn't seem to recognize that:  no modeline indicator,
>> vc commands give an error "File ... is not under version control".
>
> Is this the branch or trunk?

trunk

-miles
-- 
自らを空にして、心を開く時、道は開かれる

Re: vc.el no longer recognizes files in an arch working directory

[Miles Bader]

Miles Bader <miles.bader@necel.com> writes:
>>> Using current CVS (emacs -Q), if I visit a file in an arch working
>>> directory, vc.el doesn't seem to recognize that:  no modeline indicator,
>>> vc commands give an error "File ... is not under version control".
>>
>> Is this the branch or trunk?
>
> trunk

I just tried the same thing using the release branch -- and it has the
same problem!!

[It's a fresh checkout from CVS, built using "make bootstrap"]

-Miles

-- 
"Suppose He doesn't give a shit?  Suppose there is a God but He
just doesn't give a shit?"  [George Carlin]

Re: vc.el no longer recognizes files in an arch working directory

[Chong Yidong]

Miles Bader <miles.bader@necel.com> writes:

> Miles Bader <miles.bader@necel.com> writes:
>>>> Using current CVS (emacs -Q), if I visit a file in an arch working
>>>> directory, vc.el doesn't seem to recognize that:  no modeline indicator,
>>>> vc commands give an error "File ... is not under version control".
>>>
>>> Is this the branch or trunk?
>>
>> trunk
>
> I just tried the same thing using the release branch -- and it has the
> same problem!!

Please try to backtrack, and find out where the problem first
appeared.

Re: vc.el no longer recognizes files in an arch working directory

[Miles Bader]

... and the following patch seems to fix it:


--- orig/lisp/vc-hooks.el
+++ mod/lisp/vc-hooks.el
@@ -325,7 +325,7 @@
                    ;; to another user.  This should save us from looking in
                    ;; things like /net and /afs.  This assumes that all the
                    ;; files inside a project belong to the same user.
-                   (not (equal user (file-attributes file)))
+                   (not (equal user (nth 2 (file-attributes file))))
                    (string-match vc-ignore-dir-regexp file)))
       (if (file-exists-p (expand-file-name witness file))
          (setq root file)


So I'm going to commit this on the branch/trunk.

[Geez, people, please test stuff you commit on the release branch!]

-Miles

-- 
Saa, shall we dance?  (from a dance-class advertisement)

Re: vc.el no longer recognizes files in an arch working directory

[Glenn Morris]

Miles Bader wrote:

> [Geez, people, please test stuff you commit on the release branch!]

The responsibility in this case can only lie with the person who added
this non-essential item (originally only on the trunk) to FOR-RELEASE.

Re: vc.el no longer recognizes files in an arch working directory

[David Kastrup]

Glenn Morris <rgm@gnu.org> writes:

> Miles Bader wrote:
>
>> [Geez, people, please test stuff you commit on the release branch!]
>
> The responsibility in this case can only lie with the person who
> added this non-essential item (originally only on the trunk) to
> FOR-RELEASE.

I disagree.  The name of the file is "FOR-RELEASE", not
"FOR-BREAKING".  If I call a taxi, it does not imply that I am
responsible if the driver runs over half a dozen people on the way to
me.  And I don't see how the person putting something into FOR-RELEASE
can be held responsible for the particular code someone then places
into Emacs when he has no chance to _anticipate_ the outcome.

Unless the FOR-RELEASE item is "Please insert some random untested
stuff that looks good but will likely break."  In that case, I would
consider the person to be somewhat responsible.

-- 
David Kastrup

Re: vc.el no longer recognizes files in an arch working directory

[David Kastrup]

David Kastrup <dak@gnu.org> writes:

> Unless the FOR-RELEASE item is "Please insert some random untested
> stuff that looks good but will likely break."  In that case, I would
> consider the person to be somewhat responsible.

An afterthought I have not yet seen such an entry.  But then I might
not be checking FOR-RELEASE often enough: it would certainly explain a
lot.

-- 
David Kastrup

Re: vc.el no longer recognizes files in an arch working directory

[Stefan Monnier]

> ... and the following patch seems to fix it:
> --- orig/lisp/vc-hooks.el
> +++ mod/lisp/vc-hooks.el
> @@ -325,7 +325,7 @@
>                     ;; to another user.  This should save us from looking in
>                     ;; things like /net and /afs.  This assumes that all the
>                     ;; files inside a project belong to the same user.
> -                   (not (equal user (file-attributes file)))
> +                   (not (equal user (nth 2 (file-attributes file))))
>                     (string-match vc-ignore-dir-regexp file)))
>        (if (file-exists-p (expand-file-name witness file))
>           (setq root file)

> So I'm going to commit this on the branch/trunk.

Oops, thanks.

> [Geez, people, please test stuff you commit on the release branch!]

Sorry 'bout the typo introduce when copy&pasting between the tested code and
the installed code.  But note that I'm surprised to see this code on
the release branch.  I never intended for it to go there, never committed
there AFAIK and when Richard asked me to install it on the release branch
I explicitly said I was not confortable doing it.

Looking at the CVS log I see:

   revision 1.182.2.2
   date: 2007-05-17 03:38:11 -0400;  author: gm;  state: Exp;  lines: +8 -1;  commitid: wzJ1cmOAuE56Mfis;
   Sync change from trunk at request of rms in FOR-RELEASE:
   
   Stefan Monnier  <monnier at iro.umontreal.ca>
   
   (vc-find-root): Stop searching when the user changes.

So it looks like it was Richard's decision.


        Stefan

Re: vc.el no longer recognizes files in an arch working directory

[Richard Stallman]

    Sorry 'bout the typo introduce when copy&pasting between the tested code and
    the installed code.

Such things happen.