From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: highlight failed part of isearch input Date: Tue, 24 Jul 2007 02:33:42 +0300 Organization: JURTA Message-ID: <873aze8zl5.fsf@jurta.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1185234492 17775 80.91.229.12 (23 Jul 2007 23:48:12 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 23 Jul 2007 23:48:12 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 24 01:48:10 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ID7dK-0007Ar-2Q for ged-emacs-devel@m.gmane.org; Tue, 24 Jul 2007 01:48:10 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ID7dJ-0004Cg-6I for ged-emacs-devel@m.gmane.org; Mon, 23 Jul 2007 19:48:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ID7dE-0004B1-Je for emacs-devel@gnu.org; Mon, 23 Jul 2007 19:48:04 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ID7dC-0004Ab-4S for emacs-devel@gnu.org; Mon, 23 Jul 2007 19:48:02 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ID7dB-0004AY-KY for emacs-devel@gnu.org; Mon, 23 Jul 2007 19:48:01 -0400 Original-Received: from relay02.kiev.sovam.com ([62.64.120.197]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ID7dA-0004kF-3z; Mon, 23 Jul 2007 19:48:00 -0400 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay02.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1ID7d7-0000yL-CJ; Tue, 24 Jul 2007 02:47:58 +0300 In-Reply-To: (Drew Adams's message of "Mon\, 23 Jul 2007 15\:37\:55 -0700") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-Scanner-Signature: c2436a487120708c9e0f2b31fdd4cc45 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 1274 [July 23 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Method: none X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release X-detected-kernel: FreeBSD 4.8-5.1 (or MacOS X 10.2-10.3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:75427 Archived-At: >> (when (string-match " +$" m) >> (propertize (substring m (match-beginning 0)) 'face >> 'trailing-whitespace)) >> >> This is a no-op. But maybe it is good to remove this code because the >> failed trailing whitespace is highlighted in the new face isearch-failed. >> We could change its background to more strong color, e.g. to something >> like is used in Firefox failed search, so failed space will be >> more visible. > > Good catch. We need to change the face of the pertinent part of `m' itself, > not just a copy. Thx. The face to use for that is `trailing-whitespace', no? Why use `trailing-whitespace' when `isearch-fail' face makes failed trailing whitespace visible as well? -- Juri Linkov http://www.jurta.org/emacs/