From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thien-Thi Nguyen Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.50; vc: missing done in progress message Date: Mon, 28 Jan 2008 11:39:09 +0100 Message-ID: <873asiz12q.fsf@ambire.localdomain> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1201516917 26416 80.91.229.12 (28 Jan 2008 10:41:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Jan 2008 10:41:57 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org To: Ulrich Neumerkel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 28 11:42:17 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JJRRP-0004Du-AZ for ged-emacs-devel@m.gmane.org; Mon, 28 Jan 2008 11:42:15 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JJRQx-0005kY-SD for ged-emacs-devel@m.gmane.org; Mon, 28 Jan 2008 05:41:48 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JJRQb-0005j7-Q1 for emacs-devel@gnu.org; Mon, 28 Jan 2008 05:41:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JJRQV-0005hP-Ft for emacs-devel@gnu.org; Mon, 28 Jan 2008 05:41:24 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JJRQT-0005gw-Rs for emacs-devel@gnu.org; Mon, 28 Jan 2008 05:41:18 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JJRQT-0001dn-IU for emacs-devel@gnu.org; Mon, 28 Jan 2008 05:41:17 -0500 Original-Received: from mx10.gnu.org ([199.232.76.166]) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JJRQT-000234-Ae for emacs-pretest-bug@gnu.org; Mon, 28 Jan 2008 05:41:17 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JJRQQ-0001d2-2f for emacs-pretest-bug@gnu.org; Mon, 28 Jan 2008 05:41:17 -0500 Original-Received: from ppp-247-34.21-151.libero.it ([151.21.34.247] helo=ambire.localdomain) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JJRQP-0001cR-NI for emacs-pretest-bug@gnu.org; Mon, 28 Jan 2008 05:41:13 -0500 Original-Received: from ttn by ambire.localdomain with local (Exim 4.63) (envelope-from ) id 1JJROP-0002r4-An; Mon, 28 Jan 2008 11:39:09 +0100 In-Reply-To: (Ulrich Neumerkel's message of "Mon, 28 Jan 2008 11:00:44 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:87704 gmane.emacs.pretest.bugs:20788 Archived-At: () Ulrich Neumerkel () Mon, 28 Jan 2008 11:00:44 +0100 grep 'Finding changes in' vc.el [...] So there is no place anywhere that could acknowledge the end of the operation. In my *Messages* buffer i see such an acknowledgement. Your patch doesn't find the true end of the operation, which has two cases: synchronous and asynchronous. These are crossed with whether or not the backend program detected differences (which may or may not coincide w/ an empty output buffer, my point in the bug-gnulib thread), resulting in (at least) four cases. Furthermore, if we take into account the VERBOSE arg, which on quick analysis seems to have suffered bit-rot from the late-2007 revamp, there are now (at least) eight tails to the "Finding changes" head. Some of these cases can be (and are) coalesced, but not all. If you want "acknowledgement of end", you need to figure out *which* end you are interested in, and DTRT there, not before. Applying your patch would cause Emacs to lie (more than it does now), and we see how that turned out for HAL9000! thi