unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Thien-Thi Nguyen <ttn@gnuvola.org>
To: Ulrich Neumerkel <ulrich@complang.tuwien.ac.at>
Cc: emacs-pretest-bug@gnu.org
Subject: Re: 23.0.50; vc: missing done in progress message
Date: Mon, 28 Jan 2008 11:39:09 +0100	[thread overview]
Message-ID: <873asiz12q.fsf@ambire.localdomain> (raw)
In-Reply-To: <E1JJQnE-0003A5-Uz@a4.complang.tuwien.ac.at> (Ulrich Neumerkel's message of "Mon, 28 Jan 2008 11:00:44 +0100")

() Ulrich Neumerkel <ulrich@complang.tuwien.ac.at>
() Mon, 28 Jan 2008 11:00:44 +0100

   grep 'Finding changes in' vc.el

   [...]

   So there is no place anywhere that could acknowledge the
   end of the operation.

In my *Messages* buffer i see such an acknowledgement.

Your patch doesn't find the true end of the operation, which has two
cases: synchronous and asynchronous.  These are crossed with whether
or not the backend program detected differences (which may or may
not coincide w/ an empty output buffer, my point in the bug-gnulib
thread), resulting in (at least) four cases.  Furthermore, if we
take into account the VERBOSE arg, which on quick analysis seems to
have suffered bit-rot from the late-2007 revamp, there are now (at
least) eight tails to the "Finding changes" head.

Some of these cases can be (and are) coalesced, but not all.  If you
want "acknowledgement of end", you need to figure out *which* end
you are interested in, and DTRT there, not before.  Applying your
patch would cause Emacs to lie (more than it does now), and we see
how that turned out for HAL9000!

thi

  reply	other threads:[~2008-01-28 10:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-27 23:12 23.0.50; vc: missing done in progress message Ulrich Neumerkel
2008-01-28  4:08 ` Thien-Thi Nguyen
2008-01-28  7:57   ` Ulrich Neumerkel
2008-01-28  9:27     ` Thien-Thi Nguyen
2008-01-28 10:00       ` Ulrich Neumerkel
2008-01-28 10:39         ` Thien-Thi Nguyen [this message]
2008-01-29  8:35   ` Glenn Morris
2008-01-29  8:51     ` Thien-Thi Nguyen
2008-01-29 20:04       ` Glenn Morris
2008-01-30  8:06         ` Thien-Thi Nguyen
2008-01-31  0:56           ` Glenn Morris
2008-01-31  8:34             ` Thien-Thi Nguyen
2008-01-31 14:44               ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873asiz12q.fsf@ambire.localdomain \
    --to=ttn@gnuvola.org \
    --cc=emacs-pretest-bug@gnu.org \
    --cc=ulrich@complang.tuwien.ac.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).