From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: C-r and C-s in minibuffer should search completion Date: Tue, 22 Apr 2008 00:51:01 +0300 Organization: JURTA Message-ID: <873apec0j6.fsf@jurta.org> References: <87od8xccz6.fsf@jurta.org> <87hceouksk.fsf@jurta.org> <87y77zlqji.fsf@jurta.org> <873aq2czp4.fsf@jurta.org> <871w5j2ca1.fsf@jurta.org> <87r6d6vjg2.fsf@jurta.org> <87od89sb4y.fsf@jurta.org> <87mynsrg9m.fsf@jurta.org> <87zlrp8zn1.fsf@jurta.org> <873aph5v28.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1208816591 24145 80.91.229.12 (21 Apr 2008 22:23:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Apr 2008 22:23:11 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 22 00:23:45 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jo4Q9-0002dQ-Sp for ged-emacs-devel@m.gmane.org; Tue, 22 Apr 2008 00:23:43 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jo4PB-0000qV-Lr for ged-emacs-devel@m.gmane.org; Mon, 21 Apr 2008 18:22:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jo4P5-0000oy-E2 for emacs-devel@gnu.org; Mon, 21 Apr 2008 18:22:27 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jo4P0-0000nX-Pv for emacs-devel@gnu.org; Mon, 21 Apr 2008 18:22:26 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jo4P0-0000nA-G3 for emacs-devel@gnu.org; Mon, 21 Apr 2008 18:22:22 -0400 Original-Received: from relay02.kiev.sovam.com ([62.64.120.197]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Jo4Ou-00082u-OB for emacs-devel@gnu.org; Mon, 21 Apr 2008 18:22:21 -0400 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay02.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1Jo4Oa-000K6f-M6; Tue, 22 Apr 2008 01:21:57 +0300 In-Reply-To: (Stefan Monnier's message of "Sat, 19 Apr 2008 22:44:15 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu) X-Scanner-Signature: 88f972a75cd389d721acc69b695bb680 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 2682 [Apr 21 2008] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: none X-SpamTest-Rate: 10 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release X-detected-kernel: by monty-python.gnu.org: FreeBSD 6.x (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95710 Archived-At: >> This works correctly in the following patch: > > Looks good, feel free to install. Ah, I accidentally tested this with a Lisp version of `internal-complete-buffer' that I created earlier. But when I restored the C version of `internal-complete-buffer', it doesn't work with it. I don't understand why it works with with the equivalent Lisp version, but not with the C version. The C version returns a full buffer list disregarding the `predicate' arg. This is a working Lisp version for your reference: (defun internal-complete-buffer (string predicate flag) (let ((table (mapcar 'buffer-name (buffer-list)))) (cond ((null flag) (try-completion string table predicate)) ((eq flag t) (all-completions string table predicate t)) (t (test-completion string table predicate))))) -- Juri Linkov http://www.jurta.org/emacs/