From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Finding the source of Change Log entries Date: Sat, 12 Jul 2008 10:52:40 -0400 Message-ID: <873amfm9xj.fsf@stupidchicken.com> References: <48787A1F.1080105@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1215874384 10950 80.91.229.12 (12 Jul 2008 14:53:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 12 Jul 2008 14:53:04 +0000 (UTC) Cc: emacs-devel To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 12 16:53:51 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KHgTt-0007C8-BK for ged-emacs-devel@m.gmane.org; Sat, 12 Jul 2008 16:53:49 +0200 Original-Received: from localhost ([127.0.0.1]:50915 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KHgT1-00047L-Mi for ged-emacs-devel@m.gmane.org; Sat, 12 Jul 2008 10:52:55 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KHgSx-00047E-0i for emacs-devel@gnu.org; Sat, 12 Jul 2008 10:52:51 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KHgSu-00046q-I7 for emacs-devel@gnu.org; Sat, 12 Jul 2008 10:52:49 -0400 Original-Received: from [199.232.76.173] (port=56811 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KHgSu-00046n-BH for emacs-devel@gnu.org; Sat, 12 Jul 2008 10:52:48 -0400 Original-Received: from c-24-63-201-57.hsd1.ma.comcast.net ([24.63.201.57]:20438 helo=furry) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KHgSt-0004EA-VF for emacs-devel@gnu.org; Sat, 12 Jul 2008 10:52:48 -0400 Original-Received: by furry (Postfix, from userid 1000) id EC488C054; Sat, 12 Jul 2008 10:52:40 -0400 (EDT) In-Reply-To: <48787A1F.1080105@gmx.at> (martin rudalics's message of "Sat, 12 Jul 2008 11:32:15 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:100614 Archived-At: martin rudalics writes: > Months ago I wrote a couple of functions to find the source code > corresponding to Change Log entries. Anyone still interested? Looks good. Please check it in, with the appropriate ChangeLog and NEWS entries, plus the following fix: + (message "Not found `%s' in %s" tag file) should be something more grammatical, like + (message "Source location not found: `%s' in %s" tag file) Also, instead of binding change-log-find-tag to C-c C-t, how about using C-c C-c for consistency with diff-mode? (You might also want to rename change-log-find-tag to change-log-goto-source for consistency with diff-goto-source, but that's your call.)