From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.emacs.devel Subject: Re: epg--status-GET-HIDDEN cleanup suggestion Date: Sat, 16 Aug 2008 22:41:42 +0900 Message-ID: <873al59iw9.fsf@broken.deisui.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1218894130 18022 80.91.229.12 (16 Aug 2008 13:42:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Aug 2008 13:42:10 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ted Zlatanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 16 15:43:02 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KUM3Z-00041d-GJ for ged-emacs-devel@m.gmane.org; Sat, 16 Aug 2008 15:43:01 +0200 Original-Received: from localhost ([127.0.0.1]:60106 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KUM2c-0004LL-Su for ged-emacs-devel@m.gmane.org; Sat, 16 Aug 2008 09:42:02 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KUM2Z-0004Js-FZ for emacs-devel@gnu.org; Sat, 16 Aug 2008 09:41:59 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KUM2W-0004DR-3S for emacs-devel@gnu.org; Sat, 16 Aug 2008 09:41:58 -0400 Original-Received: from [199.232.76.173] (port=51384 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KUM2V-0004D3-Ro for emacs-devel@gnu.org; Sat, 16 Aug 2008 09:41:55 -0400 Original-Received: from yx-out-1718.google.com ([74.125.44.153]:7146) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KUM2V-00012p-G2 for emacs-devel@gnu.org; Sat, 16 Aug 2008 09:41:55 -0400 Original-Received: by yx-out-1718.google.com with SMTP id 34so812251yxf.66 for ; Sat, 16 Aug 2008 06:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type :sender; bh=LDGIQ2iFx6nR9kJ9jMh+/gNzDbVwmXQKTvaSeOWgQ6E=; b=mDk4rvMV0Mgw7dZRAYPnU8ot5mcuJbpW/KvTk6FiqlYVqifyomQr0Uee9fPRDUT7jM QlC89/hsLGhlSY16/xppFtUp8vQVXAVEBMsMuXspi9SpR55Pmq/0yEdjHRz9s29h9Ubx vuVYf2dxkzYSaDn5didCIvudjd3n6OlxuOJXY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type:sender; b=ihAMdjziv95lmIoKxT5rnCx9oeGxWTDx2oQh2Mq49FahLkinzLVpSMkNE0EWz7Cx8C 8ocBpE2Pt3pWr9GXtJH8zOZWacpFghSxpQUodp3P0yhgzEkxEHxDTKIEEA+R9RVYgqFw Lpbpt5LnqUeuBHvMOpXp0nHcZb+KHinHtkUhE= Original-Received: by 10.151.102.16 with SMTP id e16mr1746927ybm.183.1218894113898; Sat, 16 Aug 2008 06:41:53 -0700 (PDT) Original-Received: from broken ( [202.83.187.18]) by mx.google.com with ESMTPS id 7sm6914228ywo.7.2008.08.16.06.41.49 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 16 Aug 2008 06:41:52 -0700 (PDT) In-Reply-To: (Ted Zlatanov's message of "Sat, 16 Aug 2008 08:17:49 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102529 Archived-At: Ted Zlatanov writes: > The function epg--status-GET-HIDDEN in epg.el had lots of repetition, so > I cleaned it up a little with a let*. Lots of? It seems that your change binds only a few variables, and doesn't reduce the lines of code. > I don't know the protocol for comitting these cleanups, so I offer the > patch for review. It works for me. I don't like to bind variables which is used only once at run time. Regards, -- Daiki Ueno