From: Daiki Ueno <ueno@unixuser.org>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: emacs-devel@gnu.org
Subject: Re: epg--status-GET-HIDDEN cleanup suggestion
Date: Sat, 16 Aug 2008 22:41:42 +0900 [thread overview]
Message-ID: <873al59iw9.fsf@broken.deisui.org> (raw)
In-Reply-To: <m2vdy16qv6.fsf@lifelogs.com> (Ted Zlatanov's message of "Sat, 16 Aug 2008 08:17:49 -0500")
Ted Zlatanov <tzz@lifelogs.com> writes:
> The function epg--status-GET-HIDDEN in epg.el had lots of repetition, so
> I cleaned it up a little with a let*.
Lots of? It seems that your change binds only a few variables, and
doesn't reduce the lines of code.
> I don't know the protocol for comitting these cleanups, so I offer the
> patch for review. It works for me.
I don't like to bind variables which is used only once at run time.
Regards,
--
Daiki Ueno
next prev parent reply other threads:[~2008-08-16 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-16 13:17 epg--status-GET-HIDDEN cleanup suggestion Ted Zlatanov
2008-08-16 13:41 ` Daiki Ueno [this message]
2008-08-16 16:05 ` Ted Zlatanov
2008-08-18 1:16 ` Daiki Ueno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873al59iw9.fsf@broken.deisui.org \
--to=ueno@unixuser.org \
--cc=emacs-devel@gnu.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).