From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: support VC operations from dired Date: Tue, 22 Sep 2009 00:51:28 +0300 Organization: JURTA Message-ID: <873a6g0xwh.fsf@mail.jurta.org> References: <200909202122.n8KLMCIb028441@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1253570627 17901 80.91.229.12 (21 Sep 2009 22:03:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Sep 2009 22:03:47 +0000 (UTC) Cc: emacs-devel@gnu.org, Miles Bader To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 22 00:03:40 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mpqyw-0005n8-2b for ged-emacs-devel@m.gmane.org; Tue, 22 Sep 2009 00:03:39 +0200 Original-Received: from localhost ([127.0.0.1]:60115 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mpqyv-0008Ub-57 for ged-emacs-devel@m.gmane.org; Mon, 21 Sep 2009 18:03:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MpqxA-0007PU-N8 for emacs-devel@gnu.org; Mon, 21 Sep 2009 18:01:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mpqx5-0007O0-9H for emacs-devel@gnu.org; Mon, 21 Sep 2009 18:01:47 -0400 Original-Received: from [199.232.76.173] (port=43363 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mpqx5-0007Nx-5Z for emacs-devel@gnu.org; Mon, 21 Sep 2009 18:01:43 -0400 Original-Received: from smtp-out2.starman.ee ([85.253.0.4]:39596 helo=mx2.starman.ee) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mpqx1-0004GF-Ru; Mon, 21 Sep 2009 18:01:40 -0400 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Original-Received: from mail.starman.ee (82.131.69.135.cable.starman.ee [82.131.69.135]) by mx2.starman.ee (Postfix) with ESMTP id 406743F40FD; Tue, 22 Sep 2009 01:01:33 +0300 (EEST) In-Reply-To: <200909202122.n8KLMCIb028441@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 20 Sep 2009 14:22:12 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:115505 Archived-At: > Here's a minimal patch (minimally tested too) to support diff and log > from dired buffers. Thanks, it works for directories and files in Dired. I have one question: how is it supposed to log/diff the root dir from Dired? When I put point on the root dir in the dired buffer, `C-x v l' fails with: Debugger entered--Lisp error: (wrong-type-argument stringp nil) expand-file-name(nil) vc-do-command("*vc-change-log*" 0 "rlog" ...) vc-rcs-print-log(... "*vc-change-log*" t) apply(vc-rcs-print-log (... "*vc-change-log*" t)) vc-call-backend(RCS print-log (...) "*vc-change-log*" t) vc-print-log-internal(RCS (...) nil) vc-print-log() call-interactively(vc-print-log nil nil) -- Juri Linkov http://www.jurta.org/emacs/