From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: support for git commit --amend/--signoff Date: Wed, 23 Jun 2010 09:45:13 +0200 Organization: Organization?!? Message-ID: <8739we6vli.fsf@lola.goethe.zz> References: <87hblavx6f.fsf@mail.jurta.org> <874oh94kdh.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1277279185 21349 80.91.229.12 (23 Jun 2010 07:46:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 23 Jun 2010 07:46:25 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 23 09:46:22 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ORKf5-00007E-3k for ged-emacs-devel@m.gmane.org; Wed, 23 Jun 2010 09:46:19 +0200 Original-Received: from localhost ([127.0.0.1]:48204 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ORKf3-0003A0-9f for ged-emacs-devel@m.gmane.org; Wed, 23 Jun 2010 03:46:17 -0400 Original-Received: from [140.186.70.92] (port=58049 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ORKeG-00038Q-Ry for emacs-devel@gnu.org; Wed, 23 Jun 2010 03:45:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ORKeF-0000Vt-LF for emacs-devel@gnu.org; Wed, 23 Jun 2010 03:45:28 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:51717) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORKeF-0000Vn-Eb for emacs-devel@gnu.org; Wed, 23 Jun 2010 03:45:27 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1ORKeB-000806-VJ for emacs-devel@gnu.org; Wed, 23 Jun 2010 09:45:23 +0200 Original-Received: from p508ec724.dip.t-dialin.net ([80.142.199.36]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 23 Jun 2010 09:45:23 +0200 Original-Received: from dak by p508ec724.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 23 Jun 2010 09:45:23 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 25 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: p508ec724.dip.t-dialin.net X-Face: 2FEFf>]>q>2iw=B6, xrUubRI>pR&Ml9=ao@P@i)L:\urd*t9M~y1^:+Y]'C0~{mAl`oQuAl \!3KEIp?*w`|bL5qr,H)LFO6Q=qx~iH4DN; i"; /yuIsqbLLCh/!U#X[S~(5eZ41to5f%E@'ELIi$t^ Vc\LWP@J5p^rst0+('>Er0=^1{]M9!p?&:\z]|;&=NP3AhB!B_bi^]Pfkw User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:pXHdZr59EqOqoIrBPPHlvfuKezg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126334 Archived-At: Stefan Monnier writes: >>>> We could have a log-edit-extra-flags function that computes a set of >>>> extra flags, and pass those flags to vc-git-checkin. >>> If amend is triggered from a new command (like vc-amend), then there's no >>> need for any special support in log-edit. We could easily store the >>> relevant info in log-edit-callback or in vc-specific >>> buffer-local variables. >> The problem with that is that vc-amend does not integrate very well >> with C-x v v > > That doesn't bother me too much. I wish we could move further away from > C-x v v since I find it doesn't really work for modern VCSes. > >> and it is very Git specific, > > Not sure about the "very", but in any case I don't see why that would > argue for integration inside "commit" rather than for the addition of > a separate command. I thing that a zero prefix argument to C-x v v would feel quite natural for "amend". -- David Kastrup