From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add rainbow-mode Date: Wed, 04 Aug 2010 09:11:37 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <8739uubh7q.fsf@lifelogs.com> References: <1280235011-12761-1-git-send-email-julien@danjou.info> <87zkx8nb9e.fsf@lifelogs.com> <877hk9gjhp.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1280931117 10059 80.91.229.12 (4 Aug 2010 14:11:57 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 4 Aug 2010 14:11:57 +0000 (UTC) Cc: Julien Danjou To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 04 16:11:56 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OgehI-0006Oi-1U for ged-emacs-devel@m.gmane.org; Wed, 04 Aug 2010 16:11:56 +0200 Original-Received: from localhost ([127.0.0.1]:55418 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OgehH-000735-Hw for ged-emacs-devel@m.gmane.org; Wed, 04 Aug 2010 10:11:55 -0400 Original-Received: from [140.186.70.92] (port=42308 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OgehA-00072Q-AK for emacs-devel@gnu.org; Wed, 04 Aug 2010 10:11:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ogeh9-0005ST-77 for emacs-devel@gnu.org; Wed, 04 Aug 2010 10:11:48 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:54509) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ogeh8-0005SN-PS for emacs-devel@gnu.org; Wed, 04 Aug 2010 10:11:47 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Ogeh7-0006K4-VI for emacs-devel@gnu.org; Wed, 04 Aug 2010 16:11:45 +0200 Original-Received: from 38.98.147.130 ([38.98.147.130]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 04 Aug 2010 16:11:45 +0200 Original-Received: from tzz by 38.98.147.130 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 04 Aug 2010 16:11:45 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 25 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 38.98.147.130 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:PTpvCSUFX2vwu3ltT24RN/5zDEI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:128243 Archived-At: On Wed, 4 Aug 2010 10:05:00 +0200 Niels Giesen wrote: NG> This morning I finally got a chance to look at rainbow-mode. I must NG> say I like the clearness of the code. I definitely want to see wether NG> css-color.el can learn from it. NG> It seems rainbow-mode is less css-specific or more generic in that it NG> also handles LaTeX colors and x-defined-colors. On the other hand, NG> rainbow-mode does not handle all color notations valid in css (no NG> hsl()). Even if rainbow-mode.el were included in Emacs with the HSL/HSV conversions, it sounds like you still want to continue developing css-color.el (which is fine, of course). Woijciech and Lennart wanted to merge the two; it seems unlikely based on your comments. Right now rainbow-mode.el seems like a better fit for Emacs because it's more generally useful. Do you have objections to that, or do you want some time to add the features you mentioned to css-color.el and then we can reevaluate things? Julien, do you have any comments on the HSV/HSL conversions or any other part of this conversation? Ted