unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ted Zlatanov <tzz@lifelogs.com>
To: emacs-devel@gnu.org
Cc: Julien Danjou <julien@danjou.info>
Subject: Re: [PATCH] Add rainbow-mode
Date: Wed, 04 Aug 2010 09:11:37 -0500	[thread overview]
Message-ID: <8739uubh7q.fsf@lifelogs.com> (raw)
In-Reply-To: AANLkTik6dHkqf9+3uaiOxf+i9QHxe9KE3YpeTO0bFquV@mail.gmail.com

On Wed, 4 Aug 2010 10:05:00 +0200 Niels Giesen <niels.giesen@gmail.com> wrote: 

NG> This morning I finally got a chance to look at rainbow-mode. I must
NG> say I like the clearness of the code. I definitely want to see wether
NG> css-color.el can learn from it.

NG> It seems rainbow-mode is less css-specific or more generic in that it
NG> also handles LaTeX colors and x-defined-colors. On the other hand,
NG> rainbow-mode does not handle all color notations valid in css (no
NG> hsl()).

Even if rainbow-mode.el were included in Emacs with the HSL/HSV
conversions, it sounds like you still want to continue developing
css-color.el (which is fine, of course).  Woijciech and Lennart wanted
to merge the two; it seems unlikely based on your comments.

Right now rainbow-mode.el seems like a better fit for Emacs because it's
more generally useful.  Do you have objections to that, or do you want
some time to add the features you mentioned to css-color.el and then we
can reevaluate things?

Julien, do you have any comments on the HSV/HSL conversions or any other
part of this conversation?

Ted




  reply	other threads:[~2010-08-04 14:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-27 12:50 [PATCH] Add rainbow-mode Julien Danjou
2010-07-27 13:19 ` Lennart Borgman
2010-07-27 13:44   ` Drew Adams
2010-07-30 17:13     ` Ted Zlatanov
2010-07-30 22:11       ` Lennart Borgman
2010-07-30 22:59         ` Wojciech Meyer
2010-07-30 23:41           ` Lennart Borgman
2010-07-31  0:39             ` Wojciech Meyer
2010-08-02 14:46         ` Ted Zlatanov
2010-08-02 16:06           ` Lennart Borgman
2010-08-02 16:49             ` Wojciech Meyer
2010-08-04  8:05               ` Niels Giesen
2010-08-04 14:11                 ` Ted Zlatanov [this message]
2010-08-04 15:17                   ` Chong Yidong
2010-08-09  8:47                   ` Julien Danjou
2010-08-10 14:00                   ` Julien Danjou
2010-08-10 15:54                     ` Ted Zlatanov
2010-08-10 16:00                     ` Lennart Borgman
2010-08-10 18:06                       ` Julien Danjou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8739uubh7q.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=emacs-devel@gnu.org \
    --cc=julien@danjou.info \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).