From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Olivier Sirven <the.slaa@gmail.com>
Newsgroups: gmane.emacs.devel
Subject: Re: Patch for PHP5 support for etags
Date: Thu, 08 Mar 2012 10:42:46 +0100
Message-ID: <87399jjund.fsf@gandalf.home.thebuble.org>
References: <BANLkTik=7WhHUVGtyP1qX78gmcio+omjSw@mail.gmail.com>
	<E1QBRr3-0008P8-OX@tucano.isti.cnr.it>
	<BANLkTinJFfveh8S3X=SZzfOMtwVSOApigg@mail.gmail.com>
	<E1QEhKp-0001oD-R0@tucano.isti.cnr.it>
	<BANLkTi=1DO4ALzYtfAY9j2Q4VKgPNsmhPQ@mail.gmail.com>
	<87obsomsbt.fsf@gandalf.home.thebuble.org>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 8bit
X-Trace: dough.gmane.org 1331199810 32080 80.91.229.3 (8 Mar 2012 09:43:30 GMT)
X-Complaints-To: usenet@dough.gmane.org
NNTP-Posting-Date: Thu, 8 Mar 2012 09:43:30 +0000 (UTC)
To: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 08 10:43:30 2012
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1S5Zsc-0004Gc-3y
	for ged-emacs-devel@m.gmane.org; Thu, 08 Mar 2012 10:43:26 +0100
Original-Received: from localhost ([::1]:48191 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1S5Zsb-00032N-Hw
	for ged-emacs-devel@m.gmane.org; Thu, 08 Mar 2012 04:43:25 -0500
Original-Received: from eggs.gnu.org ([208.118.235.92]:41503)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ged-emacs-devel@m.gmane.org>) id 1S5ZsG-0002ft-VV
	for emacs-devel@gnu.org; Thu, 08 Mar 2012 04:43:24 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ged-emacs-devel@m.gmane.org>) id 1S5ZsF-0000dF-0y
	for emacs-devel@gnu.org; Thu, 08 Mar 2012 04:43:04 -0500
Original-Received: from plane.gmane.org ([80.91.229.3]:57956)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ged-emacs-devel@m.gmane.org>) id 1S5ZsE-0000d9-R4
	for emacs-devel@gnu.org; Thu, 08 Mar 2012 04:43:02 -0500
Original-Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <ged-emacs-devel@m.gmane.org>) id 1S5ZsB-0003hw-FP
	for emacs-devel@gnu.org; Thu, 08 Mar 2012 10:42:59 +0100
Original-Received: from home.thebuble.org ([88.160.208.28])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-devel@gnu.org>; Thu, 08 Mar 2012 10:42:59 +0100
Original-Received: from the.slaa by home.thebuble.org with local (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-devel@gnu.org>; Thu, 08 Mar 2012 10:42:59 +0100
X-Injected-Via-Gmane: http://gmane.org/
Original-Lines: 31
Original-X-Complaints-To: usenet@dough.gmane.org
X-Gmane-NNTP-Posting-Host: home.thebuble.org
User-Agent: Gnus/5.130004 (Ma Gnus v0.4) Emacs/24.0.93 (gnu/linux)
Cancel-Lock: sha1:M5zxoJz/v9Km3G0KpmaXyP1SDyY=
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 80.91.229.3
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:148929
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/148929>

On 2012-02-24 11:36:06, Olivier Sirven wrote:
> On 2011-04-26 14:36:35, Lennart Borgman wrote:
>> On Tue, Apr 26, 2011 at 2:25 PM, Francesco Potortì <pot@gnu.org> wrote:
>>>
>>> Yes, I applied the patch.  I tested it and got strange results.  So I
>>> need a php5 source file together with the expected results, so that I
>>> can check it with more confidence.  Can you provide that, or point me to
>>> someone else who can?
>>
>> Maybe some of those that have contributed to php-mode.el can?
>
> I'm no php-mode.el contributor but I do code in PHP5 every single
> working day using emacs for a long time now. 
> I was previously forcing language detection to java in order to have
> something usable even though not perfect.
>
> I've just found out about this PHP5 patch for etags and just gave it a
> try. As far as I can see it works just fine, all my declarations are
> there and I don't see any strange results.
>
> If you need any help getting this into the main code base I'd be glad to
> help. But first I need to understand what you mean by "strange results"
> so I can check whether or not I do have the same issue

I see nobody has interest into PHP5 for etags...so sad!

So maybe I'm the only one but what can/should I do to get this patch
merged?

-- 
Oliv