unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Stephen J. Turnbull" <stephen@xemacs.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: fgallina@gnu.org, Lars Magne Ingebrigtsen <larsi@gnus.org>,
	emacs-devel <emacs-devel@gnu.org>
Subject: Re: Sweeter Emacs Lisp
Date: Mon, 15 Jul 2013 14:03:52 +0900	[thread overview]
Message-ID: <8738rgtnwn.fsf@uwakimon.sk.tsukuba.ac.jp> (raw)
In-Reply-To: <87r4f0wlug.fsf@yandex.ru>

Dmitry Gutov writes:

 > >>   (defun tag-desc-stripped (tag)
 > >>     (upcase (replace-regexp-in-string "[<\\/> ]" "" (car tag))))

 > >>   (defun tag-desc-strip (tag)
 > >>     (->> (car tag) (replace-regexp-in-string "[<\\/> ]" "") (upcase)))

If you find

    (defun tag-desc-stripped (tag)
      (upcase (replace-regexp-in-string "[<\\/> ]" "" (car tag))))

hard to read, the conventional grind

    (defun tag-desc-stripped (tag)
      (upcase (replace-regexp-in-string "[<\\/> ]"
                                        ""
                                        (car tag))))

makes things pretty obvious (unless the target reader really can't
read Lisp at all).  I don't see a real need based on readability.

And this breaks C-x C-e badly.  This isn't just a matter of loss of
convenience; it's a symptom of a major syntax change.  It breaks *any*
code analysis tool.  And it is unnecessary, except for saving some
keystrokes.  You could imagine

(defun threaded-apply-to-1 (arg &rest list-of-fun)
  ;; actually, just `apply-to' is probably sufficiently mnemonic
  (while list-of-fun
    (setq arg (funcall (pop list-of-fun) arg)))
  arg)

(defun tag-desc-stripped (tag)
  (threaded-apply-to-1 tag
    #'car
    (lambda (x) (replace-regexp-in-string "[<\\/> ]" "" x))
    #'upcase))

That style makes me slightly ill, but (1) it's more general than `->'
and `->>' combined, and (2) it doesn't turn malformed function calls
into curried functions implicitly.  So it doesn't break C-x C-e and
other tools that depend on the simplicity of Lisp expression syntax.




  reply	other threads:[~2013-07-15  5:03 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-14  2:22 Sweeter Emacs Lisp fgallina
2013-07-14 11:36 ` Dmitry Gutov
2013-07-14 11:53   ` Vitalie Spinu
2013-07-14 12:38     ` Aurélien Aptel
2013-07-14 13:25     ` Xue Fuqiao
2013-07-14 14:16     ` Pascal J. Bourguignon
2013-07-14 14:22 ` Lars Magne Ingebrigtsen
2013-07-14 16:27   ` Juanma Barranquero
2013-07-14 19:43     ` Lars Magne Ingebrigtsen
2013-07-15  3:20   ` Dmitry Gutov
2013-07-15  5:03     ` Stephen J. Turnbull [this message]
2013-07-16 20:23       ` Dmitry Gutov
2013-07-17 14:04         ` Lars Magne Ingebrigtsen
2013-07-17 15:07           ` Dmitry Gutov
2013-07-16  2:15   ` Miles Bader
2013-07-16  9:12     ` Stefan Monnier
2013-07-14 16:18 ` Josh
2013-07-14 16:30   ` Juanma Barranquero
2013-07-14 17:14     ` Josh
2013-07-14 17:18       ` Juanma Barranquero
2013-07-15  6:05         ` Lars Brinkhoff
2013-07-15  7:04   ` Stefan Monnier
2013-07-15 13:30     ` Bozhidar Batsov
2013-07-16  2:26       ` Miles Bader
2013-07-16  6:08         ` Thien-Thi Nguyen
2013-07-16 14:07           ` Drew Adams
2013-07-16  9:11       ` Stefan Monnier
2013-07-14 17:24 ` Andreas Schwab
2013-07-16  2:13 ` Miles Bader
2013-07-16  6:14   ` Stephen J. Turnbull
2013-07-16  9:07   ` Stefan Monnier
2013-07-16 11:09     ` Juanma Barranquero
2013-07-16 12:25       ` Andreas Schwab
2013-07-16 13:04         ` Thierry Volpiatto
2013-07-16 13:42         ` Juanma Barranquero
2013-07-16 14:38           ` Andreas Schwab
2013-07-16 14:42             ` Juanma Barranquero
2013-07-16 20:57       ` Stefan Monnier
2013-07-22 15:24 ` Stefan Monnier
2013-07-22 16:33   ` Thien-Thi Nguyen
2013-07-22 21:04     ` Stefan Monnier
2013-07-23  4:37       ` Thien-Thi Nguyen
2013-08-10  2:52         ` Stefan Monnier
2013-08-10 10:08         ` Pascal J. Bourguignon
2013-08-10 16:27           ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738rgtnwn.fsf@uwakimon.sk.tsukuba.ac.jp \
    --to=stephen@xemacs.org \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=fgallina@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).