From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bastien Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r115918: package.el: various fixes. Date: Wed, 08 Jan 2014 18:40:25 +0100 Message-ID: <8738kyid86.fsf@bzg.ath.cx> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1389202840 15791 80.91.229.3 (8 Jan 2014 17:40:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 8 Jan 2014 17:40:40 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 08 18:40:47 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W0x7W-0001xq-15 for ged-emacs-devel@m.gmane.org; Wed, 08 Jan 2014 18:40:46 +0100 Original-Received: from localhost ([::1]:48109 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0x7V-00053L-MJ for ged-emacs-devel@m.gmane.org; Wed, 08 Jan 2014 12:40:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0x7K-00052c-S0 for emacs-devel@gnu.org; Wed, 08 Jan 2014 12:40:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0x7F-0003qH-Cr for emacs-devel@gnu.org; Wed, 08 Jan 2014 12:40:34 -0500 Original-Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:58280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0x7F-0003pQ-14; Wed, 08 Jan 2014 12:40:29 -0500 Original-Received: by mail-wg0-f50.google.com with SMTP id l18so838263wgh.17 for ; Wed, 08 Jan 2014 09:40:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=zyUHntCN5edpUtjyxN7YMBDCJE2qO4zAIjCYLf8A/s0=; b=ABtQOt5ww6BnMmpcrU65p2cQahrrrgnK8s/yJ5LyzRd8Q1YEvh913SGwLNgqNTpw7x fBl/hy5Y1peI+9jx1oVkYygCxGMzDfKvvZKh6N/Z2G8KHLtvTAy1MQY1N1lXeiXOzhxG UA8EltPl1C+WJqalI0YZY38gapfVjRItLTwyTsIUploD63BK891K1lvsrBEJpb94lLyT 4uvPUDP6ASTzWbVBvchOV+Zc0nJgI6DjjnlrUBzsEE3pB8GptLRNgJKYSk7bjZaiDZLm at7ysPUYB1+wEYsrSlkU6T4BwkpmkIBGG500rhFCuZHVjGDdqAJxYp6yO1N/xVSfRbBZ +dag== X-Received: by 10.195.13.164 with SMTP id ez4mr82378682wjd.11.1389202827992; Wed, 08 Jan 2014 09:40:27 -0800 (PST) Original-Received: from bzg.localdomain (AMontsouris-651-1-141-120.w90-46.abo.wanadoo.fr. [90.46.120.120]) by mx.google.com with ESMTPSA id ua8sm9679048wjc.4.2014.01.08.09.40.26 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jan 2014 09:40:26 -0800 (PST) Original-Received: by bzg.localdomain (Postfix, from userid 1000) id 38A2B1C20632; Wed, 8 Jan 2014 18:40:25 +0100 (CET) In-Reply-To: (Glenn Morris's message of "Wed, 08 Jan 2014 12:05:56 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:167759 Archived-At: Glenn Morris writes: >>> + (when (assq package package-alist) >>> (or >>> (let ((pkg-descs (cdr (assq package package-alist)))) > > This is redundant (accesses same thing twice). > >>> (and pkg-descs >>> (version-list-<= min-version >>> (package-desc-version (car pkg-descs))))) >>> ;; Also check built-in packages. >>> - (package-built-in-p package min-version))) >>> + (package-built-in-p package min-version)))) > > It also seems to make the "Also check built-in packages." branch > unreachable. Yes, fixed, thanks. -- Bastien