* Re: [Emacs-diffs] trunk r118326: * lisp/minibuffer.el (minibuffer-completion-help): Compare this-command with completion-at-point.
[not found] <E1XnEvz-0006Ew-DD@vcs.savannah.gnu.org>
@ 2014-12-05 2:52 ` Stefan Monnier
2014-12-05 23:42 ` Juri Linkov
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2014-12-05 2:52 UTC (permalink / raw)
To: Juri Linkov; +Cc: emacs-devel
> - ,(if (and completion-in-region-mode-predicate
> + ;; Compare `this-command' with `completion-at-point'
> + ;; since `completion--in-region-1' sets `this-command'
> + ;; to this value for region completion commands.
> + ,(if (and (eq this-command 'completion-at-point)
Any reason we can't just check (eq (selected-window) (minibuffer-window))?
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] trunk r118326: * lisp/minibuffer.el (minibuffer-completion-help): Compare this-command with completion-at-point.
2014-12-05 2:52 ` [Emacs-diffs] trunk r118326: * lisp/minibuffer.el (minibuffer-completion-help): Compare this-command with completion-at-point Stefan Monnier
@ 2014-12-05 23:42 ` Juri Linkov
2014-12-06 5:15 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Juri Linkov @ 2014-12-05 23:42 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
> Any reason we can't just check (eq (selected-window) (minibuffer-window))?
It passes all tests that I tried. Installed.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] trunk r118326: * lisp/minibuffer.el (minibuffer-completion-help): Compare this-command with completion-at-point.
2014-12-05 23:42 ` Juri Linkov
@ 2014-12-06 5:15 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2014-12-06 5:15 UTC (permalink / raw)
To: Juri Linkov; +Cc: emacs-devel
>> Any reason we can't just check (eq (selected-window) (minibuffer-window))?
> It passes all tests that I tried. Installed.
Cool, thanks, now I feel like the code actually makes sense,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-06 5:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1XnEvz-0006Ew-DD@vcs.savannah.gnu.org>
2014-12-05 2:52 ` [Emacs-diffs] trunk r118326: * lisp/minibuffer.el (minibuffer-completion-help): Compare this-command with completion-at-point Stefan Monnier
2014-12-05 23:42 ` Juri Linkov
2014-12-06 5:15 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).