* Re: scratch/tzz/tramp-histfile-override ef6a691: Introduce tramp-histfile-override.
[not found] ` <E1Y1Jtn-0005he-B6@vcs.savannah.gnu.org>
@ 2014-12-17 19:07 ` Ted Zlatanov
2014-12-17 19:27 ` Michael Albinus
2014-12-18 18:52 ` Davis Herring
2014-12-19 9:36 ` Andreas Schwab
1 sibling, 2 replies; 9+ messages in thread
From: Ted Zlatanov @ 2014-12-17 19:07 UTC (permalink / raw)
To: emacs-devel, Michael Albinus
On Wed, 17 Dec 2014 19:04:39 +0000 Teodor Zlatanov <tzz@lifelogs.com> wrote:
TZ> +(defcustom tramp-histfile-override "/dev/null"
TZ> + "Whether the HISTFILE should be overridden to something. Set
TZ> +to nil to disable the override."
TZ> + :group 'tramp
TZ> + :type '(choice (const :tag "Do not override HISTFILE" nil)
TZ> + (const :tag "Empty the history (/dev/null)" "/dev/null")
TZ> + (string :tag "Redirect to a file")))
TZ> +
Michael, what do you think about this change to tramp-sh.el? The full
patch is in branch scratch/tzz/tramp-histfile-override
Ted
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: scratch/tzz/tramp-histfile-override ef6a691: Introduce tramp-histfile-override.
2014-12-17 19:07 ` scratch/tzz/tramp-histfile-override ef6a691: Introduce tramp-histfile-override Ted Zlatanov
@ 2014-12-17 19:27 ` Michael Albinus
2014-12-17 19:55 ` Ted Zlatanov
2014-12-18 18:52 ` Davis Herring
1 sibling, 1 reply; 9+ messages in thread
From: Michael Albinus @ 2014-12-17 19:27 UTC (permalink / raw)
To: emacs-devel
Ted Zlatanov <tzz@lifelogs.com> writes:
> On Wed, 17 Dec 2014 19:04:39 +0000 Teodor Zlatanov <tzz@lifelogs.com> wrote:
>
> TZ> +(defcustom tramp-histfile-override "/dev/null"
> TZ> + "Whether the HISTFILE should be overridden to something. Set
> TZ> +to nil to disable the override."
> TZ> + :group 'tramp
> TZ> + :type '(choice (const :tag "Do not override HISTFILE" nil)
> TZ> + (const :tag "Empty the history (/dev/null)" "/dev/null")
> TZ> + (string :tag "Redirect to a file")))
> TZ> +
>
> Michael, what do you think about this change to tramp-sh.el? The full
> patch is in branch scratch/tzz/tramp-histfile-override
OK.
> Ted
Best regards, Michael.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: scratch/tzz/tramp-histfile-override ef6a691: Introduce tramp-histfile-override.
2014-12-17 19:27 ` Michael Albinus
@ 2014-12-17 19:55 ` Ted Zlatanov
2014-12-17 21:03 ` Michael Albinus
0 siblings, 1 reply; 9+ messages in thread
From: Ted Zlatanov @ 2014-12-17 19:55 UTC (permalink / raw)
To: emacs-devel
On Wed, 17 Dec 2014 20:27:01 +0100 Michael Albinus <michael.albinus@gmx.de> wrote:
MA> Ted Zlatanov <tzz@lifelogs.com> writes:
>> On Wed, 17 Dec 2014 19:04:39 +0000 Teodor Zlatanov <tzz@lifelogs.com> wrote:
>>
TZ> +(defcustom tramp-histfile-override "/dev/null"
TZ> + "Whether the HISTFILE should be overridden to something. Set
TZ> +to nil to disable the override."
TZ> + :group 'tramp
TZ> + :type '(choice (const :tag "Do not override HISTFILE" nil)
TZ> + (const :tag "Empty the history (/dev/null)" "/dev/null")
TZ> + (string :tag "Redirect to a file")))
TZ> +
>>
>> Michael, what do you think about this change to tramp-sh.el? The full
>> patch is in branch scratch/tzz/tramp-histfile-override
MA> OK.
Wonderful, thanks. Cherry-picked and scratch branch deleted.
Ted
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: scratch/tzz/tramp-histfile-override ef6a691: Introduce tramp-histfile-override.
2014-12-17 19:55 ` Ted Zlatanov
@ 2014-12-17 21:03 ` Michael Albinus
2014-12-17 21:36 ` Ted Zlatanov
0 siblings, 1 reply; 9+ messages in thread
From: Michael Albinus @ 2014-12-17 21:03 UTC (permalink / raw)
To: emacs-devel
Ted Zlatanov <tzz@lifelogs.com> writes:
> Wonderful, thanks. Cherry-picked and scratch branch deleted.
But we still add a ChangeLog entry, don't we?
> Ted
Best regards, Michael.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: scratch/tzz/tramp-histfile-override ef6a691: Introduce tramp-histfile-override.
2014-12-17 21:03 ` Michael Albinus
@ 2014-12-17 21:36 ` Ted Zlatanov
0 siblings, 0 replies; 9+ messages in thread
From: Ted Zlatanov @ 2014-12-17 21:36 UTC (permalink / raw)
To: emacs-devel
On Wed, 17 Dec 2014 22:03:07 +0100 Michael Albinus <michael.albinus@gmx.de> wrote:
MA> Ted Zlatanov <tzz@lifelogs.com> writes:
>> Wonderful, thanks. Cherry-picked and scratch branch deleted.
MA> But we still add a ChangeLog entry, don't we?
Oops, I had it in the ChangeLog but forgot to mark it on the commit.
Sorry; fixed.
Ted
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: scratch/tzz/tramp-histfile-override ef6a691: Introduce tramp-histfile-override.
2014-12-17 19:07 ` scratch/tzz/tramp-histfile-override ef6a691: Introduce tramp-histfile-override Ted Zlatanov
2014-12-17 19:27 ` Michael Albinus
@ 2014-12-18 18:52 ` Davis Herring
2014-12-19 1:33 ` Ted Zlatanov
1 sibling, 1 reply; 9+ messages in thread
From: Davis Herring @ 2014-12-18 18:52 UTC (permalink / raw)
To: Ted Zlatanov; +Cc: Michael Albinus, emacs-devel
> TZ> +(defcustom tramp-histfile-override "/dev/null"
> TZ> + "Whether the HISTFILE should be overridden to something. Set
> TZ> +to nil to disable the override."
> TZ> + :group 'tramp
> TZ> + :type '(choice (const :tag "Do not override HISTFILE" nil)
> TZ> + (const :tag "Empty the history (/dev/null)" "/dev/null")
> TZ> + (string :tag "Redirect to a file")))
> TZ> +
This may be a trivial difference, but isn't it cleaner to unset HISTFILE
than to set it to "/dev/null"?
Davis
--
This product is sold by volume, not by mass. If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: scratch/tzz/tramp-histfile-override ef6a691: Introduce tramp-histfile-override.
2014-12-18 18:52 ` Davis Herring
@ 2014-12-19 1:33 ` Ted Zlatanov
0 siblings, 0 replies; 9+ messages in thread
From: Ted Zlatanov @ 2014-12-19 1:33 UTC (permalink / raw)
To: Davis Herring; +Cc: Michael Albinus, emacs-devel
On Thu, 18 Dec 2014 11:52:40 -0700 Davis Herring <herring@lanl.gov> wrote:
TZ> +(defcustom tramp-histfile-override "/dev/null"
TZ> + "Whether the HISTFILE should be overridden to something. Set
TZ> +to nil to disable the override."
TZ> + :group 'tramp
TZ> + :type '(choice (const :tag "Do not override HISTFILE" nil)
TZ> + (const :tag "Empty the history (/dev/null)" "/dev/null")
TZ> + (string :tag "Redirect to a file")))
TZ> +
DH> This may be a trivial difference, but isn't it cleaner to unset HISTFILE
DH> than to set it to "/dev/null"?
Hi Davis,
this was pre-existing in Tramp. I think the difference is that
unsetting HISTFILE does not disable history.
Ted
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: scratch/tzz/tramp-histfile-override ef6a691: Introduce tramp-histfile-override.
[not found] ` <E1Y1Jtn-0005he-B6@vcs.savannah.gnu.org>
2014-12-17 19:07 ` scratch/tzz/tramp-histfile-override ef6a691: Introduce tramp-histfile-override Ted Zlatanov
@ 2014-12-19 9:36 ` Andreas Schwab
2014-12-20 11:16 ` Ted Zlatanov
1 sibling, 1 reply; 9+ messages in thread
From: Andreas Schwab @ 2014-12-19 9:36 UTC (permalink / raw)
To: emacs-devel; +Cc: Ted Zlatanov
Teodor Zlatanov <tzz@lifelogs.com> writes:
> ;;;###tramp-autoload
> +(defcustom tramp-histfile-override "/dev/null"
> + "Whether the HISTFILE should be overridden to something. Set
The first doc line should be a single complete sentence. Also, this is
not a predicate, so `whether' is wrong.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: scratch/tzz/tramp-histfile-override ef6a691: Introduce tramp-histfile-override.
2014-12-19 9:36 ` Andreas Schwab
@ 2014-12-20 11:16 ` Ted Zlatanov
0 siblings, 0 replies; 9+ messages in thread
From: Ted Zlatanov @ 2014-12-20 11:16 UTC (permalink / raw)
To: emacs-devel
On Fri, 19 Dec 2014 10:36:23 +0100 Andreas Schwab <schwab@linux-m68k.org> wrote:
AS> Teodor Zlatanov <tzz@lifelogs.com> writes:
>> ;;;###tramp-autoload
>> +(defcustom tramp-histfile-override "/dev/null"
>> + "Whether the HISTFILE should be overridden to something. Set
AS> The first doc line should be a single complete sentence.
Right, thank you.
AS> Also, this is not a predicate, so `whether' is wrong.
It was worded loosely and (worse) it was unhelpful. I rewrote the
docstring completely to explain the default and the options.
Ted
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-12-20 11:16 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20141217190438.21864.43602@vcs.savannah.gnu.org>
[not found] ` <E1Y1Jtn-0005he-B6@vcs.savannah.gnu.org>
2014-12-17 19:07 ` scratch/tzz/tramp-histfile-override ef6a691: Introduce tramp-histfile-override Ted Zlatanov
2014-12-17 19:27 ` Michael Albinus
2014-12-17 19:55 ` Ted Zlatanov
2014-12-17 21:03 ` Michael Albinus
2014-12-17 21:36 ` Ted Zlatanov
2014-12-18 18:52 ` Davis Herring
2014-12-19 1:33 ` Ted Zlatanov
2014-12-19 9:36 ` Andreas Schwab
2014-12-20 11:16 ` Ted Zlatanov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).