From: Oleh Krehel <ohwoeowho@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] scratch/check-declare e7e278c 1/2: check-declare.el (check-declare-ext-errors): New defcustom.
Date: Fri, 13 Feb 2015 21:22:40 +0100 [thread overview]
Message-ID: <873869mui7.fsf@gmail.com> (raw)
In-Reply-To: <jwvr3tt4lit.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Fri, 13 Feb 2015 15:17:14 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> +(defgroup check-declare nil
>> + "Check declare-function statements"
>> + :group 'tools)
>
> I think you need a "." at the end of these docstrings. C-u M-x
> checkdoc-current-buffer might flag those things (along with others with
> which I don't always agree ;-)
>
>> +(defcustom check-declare-ext-errors nil
>> + "When non-nil, warn abount functions not found in :ext"
>> + :group 'check-declare)
>
> This :group is redundant. OTOH you need a ":type 'boolean".
OK, fixed.
>
>> + (cl-letf ((warning-prefix-function
>
> Why cl-letf?
Because it works. Would you suggest something else?
Oleh
next prev parent reply other threads:[~2015-02-13 20:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150213140806.27897.63152@vcs.savannah.gnu.org>
[not found] ` <E1YMGud-0007H1-1V@vcs.savannah.gnu.org>
2015-02-13 20:17 ` [Emacs-diffs] scratch/check-declare e7e278c 1/2: check-declare.el (check-declare-ext-errors): New defcustom Stefan Monnier
2015-02-13 20:22 ` Oleh Krehel [this message]
2015-02-13 21:41 ` Artur Malabarba
2015-02-14 10:36 ` Oleh Krehel
2015-02-15 11:09 ` Oleh Krehel
2015-02-18 9:03 ` Oleh Krehel
2015-02-24 16:20 ` Oleh Krehel
[not found] ` <E1YMGud-0007HA-HJ@vcs.savannah.gnu.org>
2015-02-13 21:49 ` [Emacs-diffs] scratch/check-declare 1d5cdf1 2/2: check-declare.el: Use compilation-style warnings Artur Malabarba
2015-02-13 21:53 ` Artur Malabarba
2015-02-14 10:36 ` Oleh Krehel
2015-02-14 12:00 ` Artur Malabarba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873869mui7.fsf@gmail.com \
--to=ohwoeowho@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).